diff mbox

[PULL,16/58] file-win32: Error out if locking=on

Message ID 1494513181-7900-17-git-send-email-kwolf@redhat.com
State New
Headers show

Commit Message

Kevin Wolf May 11, 2017, 2:32 p.m. UTC 
From: Fam Zheng <famz@redhat.com>

We share the same set of QAPI options with file-posix, but locking is
not supported here. So error out if it is specified as 'on' for now.

Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/file-win32.c | 5 +++++
 1 file changed, 5 insertions(+)
diff mbox

Patch

diff --git a/block/file-win32.c b/block/file-win32.c
index d1eb0a1..1a35dba 100644
--- a/block/file-win32.c
+++ b/block/file-win32.c
@@ -344,6 +344,11 @@  static int raw_open(BlockDriverState *bs, QDict *options, int flags,
         goto fail;
     }
 
+    if (qdict_get_try_bool(options, "locking", false)) {
+        error_setg(errp, "locking=on is not supported on Windows");
+        goto fail;
+    }
+
     filename = qemu_opt_get(opts, "filename");
 
     use_aio = get_aio_option(opts, flags, &local_err);