diff mbox

[U-Boot,2/2] regulator: pfuze100: unsigned compared against 0

Message ID 1494470101-23193-2-git-send-email-peng.fan@nxp.com
State Accepted
Commit fcdb5319ceae7c55450053defc031749d6a7da57
Delegated to: Stefano Babic
Headers show

Commit Message

Peng Fan May 11, 2017, 2:35 a.m. UTC
Fix unsigned compared against 0.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>
---
 drivers/power/regulator/pfuze100.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Jaehoon Chung May 25, 2017, 1:38 p.m. UTC | #1
On 05/11/2017 11:35 AM, Peng Fan wrote:
> Fix unsigned compared against 0.

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> ---
>  drivers/power/regulator/pfuze100.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/power/regulator/pfuze100.c b/drivers/power/regulator/pfuze100.c
> index 88b1b72..02f3894 100644
> --- a/drivers/power/regulator/pfuze100.c
> +++ b/drivers/power/regulator/pfuze100.c
> @@ -314,7 +314,7 @@ static int pfuze100_regulator_probe(struct udevice *dev)
>  
>  static int pfuze100_regulator_mode(struct udevice *dev, int op, int *opmode)
>  {
> -	unsigned char val;
> +	int val;
>  	struct pfuze100_regulator_platdata *plat = dev_get_platdata(dev);
>  	struct pfuze100_regulator_desc *desc = plat->desc;
>  
> @@ -384,7 +384,7 @@ static int pfuze100_regulator_mode(struct udevice *dev, int op, int *opmode)
>  
>  static int pfuze100_regulator_enable(struct udevice *dev, int op, bool *enable)
>  {
> -	unsigned char val;
> +	int val;
>  	int ret, on_off;
>  	struct dm_regulator_uclass_platdata *uc_pdata =
>  		dev_get_uclass_platdata(dev);
> @@ -448,7 +448,7 @@ static int pfuze100_regulator_enable(struct udevice *dev, int op, bool *enable)
>  static int pfuze100_regulator_val(struct udevice *dev, int op, int *uV)
>  {
>  	int i;
> -	unsigned char val;
> +	int val;
>  	struct pfuze100_regulator_platdata *plat = dev_get_platdata(dev);
>  	struct pfuze100_regulator_desc *desc = plat->desc;
>  	struct dm_regulator_uclass_platdata *uc_pdata =
>
diff mbox

Patch

diff --git a/drivers/power/regulator/pfuze100.c b/drivers/power/regulator/pfuze100.c
index 88b1b72..02f3894 100644
--- a/drivers/power/regulator/pfuze100.c
+++ b/drivers/power/regulator/pfuze100.c
@@ -314,7 +314,7 @@  static int pfuze100_regulator_probe(struct udevice *dev)
 
 static int pfuze100_regulator_mode(struct udevice *dev, int op, int *opmode)
 {
-	unsigned char val;
+	int val;
 	struct pfuze100_regulator_platdata *plat = dev_get_platdata(dev);
 	struct pfuze100_regulator_desc *desc = plat->desc;
 
@@ -384,7 +384,7 @@  static int pfuze100_regulator_mode(struct udevice *dev, int op, int *opmode)
 
 static int pfuze100_regulator_enable(struct udevice *dev, int op, bool *enable)
 {
-	unsigned char val;
+	int val;
 	int ret, on_off;
 	struct dm_regulator_uclass_platdata *uc_pdata =
 		dev_get_uclass_platdata(dev);
@@ -448,7 +448,7 @@  static int pfuze100_regulator_enable(struct udevice *dev, int op, bool *enable)
 static int pfuze100_regulator_val(struct udevice *dev, int op, int *uV)
 {
 	int i;
-	unsigned char val;
+	int val;
 	struct pfuze100_regulator_platdata *plat = dev_get_platdata(dev);
 	struct pfuze100_regulator_desc *desc = plat->desc;
 	struct dm_regulator_uclass_platdata *uc_pdata =