From patchwork Sat Dec 18 18:39:00 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 76090 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 52911B70AA for ; Sun, 19 Dec 2010 05:39:59 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932148Ab0LRSjW (ORCPT ); Sat, 18 Dec 2010 13:39:22 -0500 Received: from mail-wy0-f174.google.com ([74.125.82.174]:50269 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932100Ab0LRSjO (ORCPT ); Sat, 18 Dec 2010 13:39:14 -0500 Received: by mail-wy0-f174.google.com with SMTP id 28so1698587wyb.19 for ; Sat, 18 Dec 2010 10:39:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=L1VmkWXgfexBFYxEiSOvDCtm9Uojra5Tc/e5e7LmRIY=; b=GE28q+16DSzowSQXdHSZiA0sumoaY488zt7l1kl08Aw1r/ZgQIiA/wQU7lNcF+gv7A IiIyy1kCPVBmFJu6C9fakwpSGPatP3SW7jccgNSFPSFTcM6rsrD4rZ1LYD/1GS0sWsNQ 1oNb0mbA6J64UGUXwrxMdltm3PrKd/g8Txi7A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=VVEj2dwC22mG0pXphGrs6zVdCAEb4/tIXVPexkiV3Ynmi/soiwdwFkCTngc72d4FZ2 PXFKuyjIB6LBScoEQ5DM6/Dm55Q9RQ9HDHEPbpo2T/IyzfZsDLIgX7On4Nvg2gA6LO+V BHa5YNVMPNjzIhVLfAIsGzLfMZ8n1OIop7JRw= Received: by 10.216.166.67 with SMTP id f45mr322750wel.112.1292697553411; Sat, 18 Dec 2010 10:39:13 -0800 (PST) Received: from localhost.localdomain (pat35-2-82-240-214-173.fbx.proxad.net [82.240.214.173]) by mx.google.com with ESMTPS id e12sm905955wer.36.2010.12.18.10.39.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 18 Dec 2010 10:39:12 -0800 (PST) From: Jean-Michel Hautbois To: davem@davemloft.net Cc: richard.cochran@omicron.at, shemminger@vyatta.com, tj@kernel.org, randy.dunlap@oracle.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jean-Michel Hautbois Subject: [PATCH 2/2] net: phy: Fixed some checkpatch errors Date: Sat, 18 Dec 2010 19:39:00 +0100 Message-Id: <1292697540-2723-2-git-send-email-jhautbois@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1292697540-2723-1-git-send-email-jhautbois@gmail.com> References: <1292697540-2723-1-git-send-email-jhautbois@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes some coding style issues (errors and warnings). Signed-off-by: Jean-Michel Hautbois --- drivers/net/phy/phy.c | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index b28f2ac..69758b4 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -33,10 +33,10 @@ #include #include -#include -#include +#include +#include #include -#include +#include /** * phy_print_status - Convenience function to print out the current phy status @@ -47,11 +47,11 @@ void phy_print_status(struct phy_device *phydev) pr_info("PHY: %s - Link is %s", dev_name(&phydev->dev), phydev->link ? "Up" : "Down"); if (phydev->link) - printk(" - %d/%s", phydev->speed, + pr_info(" - %d/%s", phydev->speed, DUPLEX_FULL == phydev->duplex ? "Full" : "Half"); - printk("\n"); + pr_info("\n"); } EXPORT_SYMBOL(phy_print_status); @@ -325,7 +325,7 @@ int phy_mii_ioctl(struct phy_device *phydev, case SIOCSMIIREG: if (mii_data->phy_id == phydev->addr) { - switch(mii_data->reg_num) { + switch (mii_data->reg_num) { case MII_BMCR: if ((val & (BMCR_RESET|BMCR_ANENABLE)) == 0) phydev->autoneg = AUTONEG_DISABLE; @@ -352,7 +352,7 @@ int phy_mii_ioctl(struct phy_device *phydev, } phy_write(phydev, mii_data->reg_num, val); - + if (mii_data->reg_num == MII_BMCR && val & BMCR_RESET && phydev->drv->config_init) { @@ -471,7 +471,7 @@ static void phy_force_reduction(struct phy_device *phydev) int idx; idx = phy_find_setting(phydev->speed, phydev->duplex); - + idx++; idx = phy_find_valid(idx, phydev->supported); @@ -732,6 +732,7 @@ out_unlock: * will not reenable interrupts. */ } +EXPORT_SYMBOL(phy_stop); /** @@ -762,7 +763,6 @@ void phy_start(struct phy_device *phydev) } mutex_unlock(&phydev->lock); } -EXPORT_SYMBOL(phy_stop); EXPORT_SYMBOL(phy_start); /** @@ -782,7 +782,7 @@ void phy_state_machine(struct work_struct *work) if (phydev->adjust_state) phydev->adjust_state(phydev->attached_dev); - switch(phydev->state) { + switch (phydev->state) { case PHY_DOWN: case PHY_STARTING: case PHY_READY: