diff mbox

[U-Boot,8/8] tpm: Fix comparison of unsigned expression warning

Message ID 1494444018-2748-8-git-send-email-trini@konsulko.com
State Accepted
Commit 667d6856973c725331f70eb9f36fee8897123316
Delegated to: Tom Rini
Headers show

Commit Message

Tom Rini May 10, 2017, 7:20 p.m. UTC
The function tpm_xfer returns int so make 'err' be int rather than
uint32_t so that we can catch an error condition.  Reported by
clang-3.8.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
 lib/tpm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Tom Rini May 12, 2017, 5:24 p.m. UTC | #1
On Wed, May 10, 2017 at 03:20:18PM -0400, Tom Rini wrote:

> The function tpm_xfer returns int so make 'err' be int rather than
> uint32_t so that we can catch an error condition.  Reported by
> clang-3.8.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/lib/tpm.c b/lib/tpm.c
index cd7f88f2204e..fb520e3d733c 100644
--- a/lib/tpm.c
+++ b/lib/tpm.c
@@ -230,10 +230,9 @@  static uint32_t tpm_sendrecv_command(const void *command,
 		void *response, size_t *size_ptr)
 {
 	struct udevice *dev;
-	int ret;
+	int err, ret;
 	uint8_t response_buffer[COMMAND_BUFFER_SIZE];
 	size_t response_length;
-	uint32_t err;
 
 	if (response) {
 		response_length = *size_ptr;