| Submitter | Andreas Färber |
|---|---|
| Date | Dec. 18, 2010, 4:25 p.m. |
| Message ID | <1292689531-18763-1-git-send-email-andreas.faerber@web.de> |
| Download | mbox | patch |
| Permalink | /patch/76077/ |
| State | New |
| Headers | show |
Comments
On Sat, Dec 18, 2010 at 4:25 PM, Andreas Färber <andreas.faerber@web.de> wrote: > softfloat.h's uint32 type has least-width semantics, > whereas surrounding code uses uint32_t, so use uint32_t too. I think patches 1 to 3 don't have much to do with softfloat, the type uses are just general sloppiness to use non-standard types instead of deliberate softfloat type use. So if there is a respin for some reason, please split off those from the softfloat patches and adjust the descriptions. Otherwise, if the patches are going to be applied, splitting is not necessary.
Patch
diff --git a/hw/apic.c b/hw/apic.c index a5a53fb..ff581f0 100644 --- a/hw/apic.c +++ b/hw/apic.c @@ -765,7 +765,7 @@ static uint32_t apic_mem_readl(void *opaque, target_phys_addr_t addr) return val; } -static void apic_send_msi(target_phys_addr_t addr, uint32 data) +static void apic_send_msi(target_phys_addr_t addr, uint32_t data) { uint8_t dest = (addr & MSI_ADDR_DEST_ID_MASK) >> MSI_ADDR_DEST_ID_SHIFT; uint8_t vector = (data & MSI_DATA_VECTOR_MASK) >> MSI_DATA_VECTOR_SHIFT;
softfloat.h's uint32 type has least-width semantics, whereas surrounding code uses uint32_t, so use uint32_t too. v3: * Split off. Signed-off-by: Andreas Färber <andreas.faerber@web.de> --- hw/apic.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)