Patchwork [v3,3/7] target-i386: Don't use SoftFloat uint64 type

login
register
mail settings
Submitter Andreas Färber
Date Dec. 18, 2010, 4:25 p.m.
Message ID <1292689531-18763-3-git-send-email-andreas.faerber@web.de>
Download mbox | patch
Permalink /patch/76076/
State New
Headers show

Comments

Andreas Färber - Dec. 18, 2010, 4:25 p.m.
softfloat.h's uint64 type has least-width semantics,
which seems unintended here since uint64_t is used in helpers.

v3:
* Split off.

Cc: Huang Ying <ying.huang@intel.com>
Cc: Juan Quintela <quintela@redhat.com>
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
---
 target-i386/cpu.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Juan Quintela - Dec. 18, 2010, 8:19 p.m.
Andreas Färber <andreas.faerber@web.de> wrote:
> softfloat.h's uint64 type has least-width semantics,
> which seems unintended here since uint64_t is used in helpers.
>
> v3:
> * Split off.

Acked-by: Juan Quintela <quintela@redhat.com>

Some days I feel the urgency of removing all the typealiases of
softfloat.h :(


> Cc: Huang Ying <ying.huang@intel.com>
> Cc: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> ---
>  target-i386/cpu.h |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 06e40f3..f0c07cd 100644
> --- a/target-i386/cpu.h
> +++ b/target-i386/cpu.h
> @@ -737,10 +737,10 @@ typedef struct CPUX86State {
>         user */
>      struct DeviceState *apic_state;
>  
> -    uint64 mcg_cap;
> -    uint64 mcg_status;
> -    uint64 mcg_ctl;
> -    uint64 mce_banks[MCE_BANKS_DEF*4];
> +    uint64_t mcg_cap;
> +    uint64_t mcg_status;
> +    uint64_t mcg_ctl;
> +    uint64_t mce_banks[MCE_BANKS_DEF*4];
>  
>      uint64_t tsc_aux;
Huang Ying - Dec. 20, 2010, 12:52 a.m.
On Sun, 2010-12-19 at 00:25 +0800, Andreas Färber wrote:
> softfloat.h's uint64 type has least-width semantics,
> which seems unintended here since uint64_t is used in helpers.
> 
> v3:
> * Split off.
> 
> Cc: Huang Ying <ying.huang@intel.com>
> Cc: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>

Acked-by: Huang Ying <ying.huang@intel.com>

Patch

diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index 06e40f3..f0c07cd 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -737,10 +737,10 @@  typedef struct CPUX86State {
        user */
     struct DeviceState *apic_state;
 
-    uint64 mcg_cap;
-    uint64 mcg_status;
-    uint64 mcg_ctl;
-    uint64 mce_banks[MCE_BANKS_DEF*4];
+    uint64_t mcg_cap;
+    uint64_t mcg_status;
+    uint64_t mcg_ctl;
+    uint64_t mce_banks[MCE_BANKS_DEF*4];
 
     uint64_t tsc_aux;