| Message ID | 20170510070115.13063-1-david@gibson.dropbear.id.au |
|---|---|
| State | New |
| Headers | show |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20170510070115.13063-1-david@gibson.dropbear.id.au
Type: series
Subject: [Qemu-devel] [PULL 00/22] ppc-for-2.10 queue 20170510
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
1b70f29 pnv: Fix build failures on some host platforms
86671f8 target/ppc: Allow workarounds for POWER9 DD1
6cedee8 spapr: Don't accidentally advertise HTM support on POWER9
6977773 ppc: xics: fix compilation with CentOS 6
eafc8f5 target/ppc: Enable RADIX mmu mode for pseries TCG guest
0695293 target/ppc: Implement ISA V3.00 radix page fault handler
44c9403 target/ppc: Change tlbie invalid fields for POWER9 support
9b09287 target/ppc: Update tlbie to check privilege level based on GTSE
d1a36ba target/ppc: Set UPRT and GTSE on all cpus in H_REGISTER_PROCESS_TABLE
7cf9c6f ppc: add qemu_vga.ndrv ROM to fw_cfg interface for NewWorld Macs
dd211ca ppc: add qemu_vga.ndrv ROM to fw_cfg interface for OldWorld Macs
757323f Add QemuMacDrivers qemu_vga.ndrv revision d4e7d7a built as submodule
636240c Add QemuMacDrivers as submodule
bd86886 ppc/xics: preserve P and Q bits for KVM IRQs
c769966 ppc/xics: Fix stale irq->status bits after get
fe7ce46 target/ppc: do not reset reserve_addr in exec_enter
48eb3bf tcg: enable MTTCG by default for PPC64 on x86
46bdb83 cpus: Fix CPU unplug for MTTCG
64d1b41 target/ppc: Generate fence operations
688eb24 cputlb: handle first atomic write to the page
625734c target/ppc: Emulate LL/SC using cmpxchg helpers
d736912 ppc/pnv: restrict BMC object to the BMC simulator
=== OUTPUT BEGIN ===
Checking PATCH 1/22: ppc/pnv: restrict BMC object to the BMC simulator...
Checking PATCH 2/22: target/ppc: Emulate LL/SC using cmpxchg helpers...
Checking PATCH 3/22: cputlb: handle first atomic write to the page...
Checking PATCH 4/22: target/ppc: Generate fence operations...
Checking PATCH 5/22: cpus: Fix CPU unplug for MTTCG...
Checking PATCH 6/22: tcg: enable MTTCG by default for PPC64 on x86...
Checking PATCH 7/22: target/ppc: do not reset reserve_addr in exec_enter...
Checking PATCH 8/22: ppc/xics: Fix stale irq->status bits after get...
Checking PATCH 9/22: ppc/xics: preserve P and Q bits for KVM IRQs...
Checking PATCH 10/22: Add QemuMacDrivers as submodule...
Checking PATCH 11/22: Add QemuMacDrivers qemu_vga.ndrv revision d4e7d7a built as submodule...
Checking PATCH 12/22: ppc: add qemu_vga.ndrv ROM to fw_cfg interface for OldWorld Macs...
Checking PATCH 13/22: ppc: add qemu_vga.ndrv ROM to fw_cfg interface for NewWorld Macs...
Checking PATCH 14/22: target/ppc: Set UPRT and GTSE on all cpus in H_REGISTER_PROCESS_TABLE...
Checking PATCH 15/22: target/ppc: Update tlbie to check privilege level based on GTSE...
Checking PATCH 16/22: target/ppc: Change tlbie invalid fields for POWER9 support...
Checking PATCH 17/22: target/ppc: Implement ISA V3.00 radix page fault handler...
ERROR: Macros with complex values should be enclosed in parenthesis
#413: FILE: target/ppc/mmu-radix64.h:19:
+#define PRTBE_R_GET_RTS(rts) (((rts >> 58) & 0x18) | ((rts >> 5) & 0x7)) + 31
total: 1 errors, 0 warnings, 373 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 18/22: target/ppc: Enable RADIX mmu mode for pseries TCG guest...
Checking PATCH 19/22: ppc: xics: fix compilation with CentOS 6...
Checking PATCH 20/22: spapr: Don't accidentally advertise HTM support on POWER9...
Checking PATCH 21/22: target/ppc: Allow workarounds for POWER9 DD1...
Checking PATCH 22/22: pnv: Fix build failures on some host platforms...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
On Wed, May 10, 2017 at 12:50:29AM -0700, no-reply@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Message-id: 20170510070115.13063-1-david@gibson.dropbear.id.au > Type: series > Subject: [Qemu-devel] [PULL 00/22] ppc-for-2.10 queue 20170510 > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > 1b70f29 pnv: Fix build failures on some host platforms > 86671f8 target/ppc: Allow workarounds for POWER9 DD1 > 6cedee8 spapr: Don't accidentally advertise HTM support on POWER9 > 6977773 ppc: xics: fix compilation with CentOS 6 > eafc8f5 target/ppc: Enable RADIX mmu mode for pseries TCG guest > 0695293 target/ppc: Implement ISA V3.00 radix page fault handler > 44c9403 target/ppc: Change tlbie invalid fields for POWER9 support > 9b09287 target/ppc: Update tlbie to check privilege level based on GTSE > d1a36ba target/ppc: Set UPRT and GTSE on all cpus in H_REGISTER_PROCESS_TABLE > 7cf9c6f ppc: add qemu_vga.ndrv ROM to fw_cfg interface for NewWorld Macs > dd211ca ppc: add qemu_vga.ndrv ROM to fw_cfg interface for OldWorld Macs > 757323f Add QemuMacDrivers qemu_vga.ndrv revision d4e7d7a built as submodule > 636240c Add QemuMacDrivers as submodule > bd86886 ppc/xics: preserve P and Q bits for KVM IRQs > c769966 ppc/xics: Fix stale irq->status bits after get > fe7ce46 target/ppc: do not reset reserve_addr in exec_enter > 48eb3bf tcg: enable MTTCG by default for PPC64 on x86 > 46bdb83 cpus: Fix CPU unplug for MTTCG > 64d1b41 target/ppc: Generate fence operations > 688eb24 cputlb: handle first atomic write to the page > 625734c target/ppc: Emulate LL/SC using cmpxchg helpers > d736912 ppc/pnv: restrict BMC object to the BMC simulator > > === OUTPUT BEGIN === > Checking PATCH 1/22: ppc/pnv: restrict BMC object to the BMC simulator... > Checking PATCH 2/22: target/ppc: Emulate LL/SC using cmpxchg helpers... > Checking PATCH 3/22: cputlb: handle first atomic write to the page... > Checking PATCH 4/22: target/ppc: Generate fence operations... > Checking PATCH 5/22: cpus: Fix CPU unplug for MTTCG... > Checking PATCH 6/22: tcg: enable MTTCG by default for PPC64 on x86... > Checking PATCH 7/22: target/ppc: do not reset reserve_addr in exec_enter... > Checking PATCH 8/22: ppc/xics: Fix stale irq->status bits after get... > Checking PATCH 9/22: ppc/xics: preserve P and Q bits for KVM IRQs... > Checking PATCH 10/22: Add QemuMacDrivers as submodule... > Checking PATCH 11/22: Add QemuMacDrivers qemu_vga.ndrv revision d4e7d7a built as submodule... > Checking PATCH 12/22: ppc: add qemu_vga.ndrv ROM to fw_cfg interface for OldWorld Macs... > Checking PATCH 13/22: ppc: add qemu_vga.ndrv ROM to fw_cfg interface for NewWorld Macs... > Checking PATCH 14/22: target/ppc: Set UPRT and GTSE on all cpus in H_REGISTER_PROCESS_TABLE... > Checking PATCH 15/22: target/ppc: Update tlbie to check privilege level based on GTSE... > Checking PATCH 16/22: target/ppc: Change tlbie invalid fields for POWER9 support... > Checking PATCH 17/22: target/ppc: Implement ISA V3.00 radix page fault handler... > ERROR: Macros with complex values should be enclosed in parenthesis > #413: FILE: target/ppc/mmu-radix64.h:19: > +#define PRTBE_R_GET_RTS(rts) (((rts >> 58) & 0x18) | ((rts >> 5) & 0x7)) + 31 Crud. that's actually an important one, I should have caught it. > total: 1 errors, 0 warnings, 373 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 18/22: target/ppc: Enable RADIX mmu mode for pseries TCG guest... > Checking PATCH 19/22: ppc: xics: fix compilation with CentOS 6... > Checking PATCH 20/22: spapr: Don't accidentally advertise HTM support on POWER9... > Checking PATCH 21/22: target/ppc: Allow workarounds for POWER9 DD1... > Checking PATCH 22/22: pnv: Fix build failures on some host platforms... > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-devel@freelists.org
The following changes since commit dd1559bb267becbb838de41132ef60771d183e5d: Merge remote-tracking branch 'elmarco/tags/chr-tests-pull-request' into staging (2017-05-05 17:07:55 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.10-20170510 for you to fetch changes up to ca1de9d144f11e52f0e67c8d78b4206b2849eff0: pnv: Fix build failures on some host platforms (2017-05-10 16:46:01 +1000) ---------------------------------------------------------------- ppc patch queue for 2017-05-10 Highlights of this set: * Some fixes for POWER9 * TCG support for POWER9 radix MMU * VGA rom for Mac machine types * Fixes for the XICS interrupt controller * MTTCG support for ppc targets As suggested by Paolo, I've tried to add the Docker tests to my standard pre-pull-request tests. I haven't wholly suceeded; this has been tested with some of the Docker images, but others I haven't managed due to problems that as best I can tell are not due to problems in this patch series. I'll continue working on this for future pull requests. ---------------------------------------------------------------- Bharata B Rao (1): cpus: Fix CPU unplug for MTTCG Cédric Le Goater (1): ppc/pnv: restrict BMC object to the BMC simulator David Gibson (3): spapr: Don't accidentally advertise HTM support on POWER9 target/ppc: Allow workarounds for POWER9 DD1 pnv: Fix build failures on some host platforms Mark Cave-Ayland (4): Add QemuMacDrivers as submodule Add QemuMacDrivers qemu_vga.ndrv revision d4e7d7a built as submodule ppc: add qemu_vga.ndrv ROM to fw_cfg interface for OldWorld Macs ppc: add qemu_vga.ndrv ROM to fw_cfg interface for NewWorld Macs Nikunj A Dadhania (5): target/ppc: Emulate LL/SC using cmpxchg helpers cputlb: handle first atomic write to the page target/ppc: Generate fence operations tcg: enable MTTCG by default for PPC64 on x86 target/ppc: do not reset reserve_addr in exec_enter Paolo Bonzini (1): ppc: xics: fix compilation with CentOS 6 Sam Bobroff (2): ppc/xics: Fix stale irq->status bits after get ppc/xics: preserve P and Q bits for KVM IRQs Suraj Jitindar Singh (5): target/ppc: Set UPRT and GTSE on all cpus in H_REGISTER_PROCESS_TABLE target/ppc: Update tlbie to check privilege level based on GTSE target/ppc: Change tlbie invalid fields for POWER9 support target/ppc: Implement ISA V3.00 radix page fault handler target/ppc: Enable RADIX mmu mode for pseries TCG guest .gitmodules | 3 + Makefile | 3 +- configure | 2 + cpus.c | 6 + cputlb.c | 8 +- hw/intc/xics_kvm.c | 13 +++ hw/ppc/mac_newworld.c | 18 ++- hw/ppc/mac_oldworld.c | 18 ++- hw/ppc/pnv.c | 2 +- hw/ppc/spapr.c | 17 ++- hw/ppc/spapr_hcall.c | 18 ++- include/hw/ppc/pnv.h | 3 +- include/hw/ppc/pnv_lpc.h | 4 +- include/hw/ppc/pnv_occ.h | 4 +- include/hw/ppc/xics.h | 4 +- pc-bios/README | 3 + pc-bios/qemu_vga.ndrv | Bin 0 -> 14752 bytes roms/QemuMacDrivers | 1 + target/ppc/Makefile.objs | 1 + target/ppc/cpu-models.h | 1 + target/ppc/cpu.h | 4 + target/ppc/excp_helper.c | 3 + target/ppc/kvm.c | 11 ++ target/ppc/mmu-book3s-v3.c | 6 +- target/ppc/mmu-book3s-v3.h | 5 + target/ppc/mmu-radix64.c | 259 ++++++++++++++++++++++++++++++++++++++++++++ target/ppc/mmu-radix64.h | 71 ++++++++++++ target/ppc/translate.c | 48 ++++++-- target/ppc/translate_init.c | 11 +- 29 files changed, 498 insertions(+), 49 deletions(-) create mode 100644 pc-bios/qemu_vga.ndrv create mode 160000 roms/QemuMacDrivers create mode 100644 target/ppc/mmu-radix64.c create mode 100644 target/ppc/mmu-radix64.h