diff mbox

[1/4] hamradio: Combine two seq_printf() calls into one in yam_seq_show()

Message ID c2866b46-28c9-f17f-dce7-96425a17a43a@users.sourceforge.net
State Rejected, archived
Delegated to: David Miller
Headers show

Commit Message

SF Markus Elfring May 9, 2017, 2:22 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 9 May 2017 14:16:45 +0200

A bit of data was put into a sequence by two separate function calls.
Print the same data by a single function call instead.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/hamradio/yam.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

David Laight May 10, 2017, 8:48 a.m. UTC | #1 
From: SF Markus Elfring

> Sent: 09 May 2017 15:22

> A bit of data was put into a sequence by two separate function calls.

> Print the same data by a single function call instead.

> 

> This issue was detected by using the Coccinelle software.

> 

> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

> ---

>  drivers/net/hamradio/yam.c | 3 +--

>  1 file changed, 1 insertion(+), 2 deletions(-)

> 

> diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c

> index b6891ada1d7b..542f1e511df1 100644

> --- a/drivers/net/hamradio/yam.c

> +++ b/drivers/net/hamradio/yam.c

> @@ -830,8 +830,7 @@ static int yam_seq_show(struct seq_file *seq, void *v)

>  	seq_printf(seq, "  RxFrames %lu\n", dev->stats.rx_packets);

>  	seq_printf(seq, "  TxInt    %u\n", yp->nb_mdint);

>  	seq_printf(seq, "  RxInt    %u\n", yp->nb_rxint);

> -	seq_printf(seq, "  RxOver   %lu\n", dev->stats.rx_fifo_errors);

> -	seq_printf(seq, "\n");

> +	seq_printf(seq, "  RxOver   %lu\n\n", dev->stats.rx_fifo_errors);

>  	return 0;


The code was consistently (and probably deliberately) using one seq_printf()
call for each line so that the source looks 'a bit like' the output.

These changes are all stupid.

	David
diff mbox

Patch

diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
index b6891ada1d7b..542f1e511df1 100644
--- a/drivers/net/hamradio/yam.c
+++ b/drivers/net/hamradio/yam.c
@@ -830,8 +830,7 @@  static int yam_seq_show(struct seq_file *seq, void *v)
 	seq_printf(seq, "  RxFrames %lu\n", dev->stats.rx_packets);
 	seq_printf(seq, "  TxInt    %u\n", yp->nb_mdint);
 	seq_printf(seq, "  RxInt    %u\n", yp->nb_rxint);
-	seq_printf(seq, "  RxOver   %lu\n", dev->stats.rx_fifo_errors);
-	seq_printf(seq, "\n");
+	seq_printf(seq, "  RxOver   %lu\n\n", dev->stats.rx_fifo_errors);
 	return 0;
 }