diff mbox

[U-Boot,V2,2/2] asm-generic: global_data: change timebase_l/h to unsigned int

Message ID 1494297123-20513-2-git-send-email-peng.fan@nxp.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Peng Fan May 9, 2017, 2:32 a.m. UTC 
Change type of timebase_l/h to unsigned int.
From lib/time.c: ((uint64_t)gd->timebase_h << 32) | gd->timebase_l;
This piece code is based on that timebase_h and timebase_l are
32bits width, so change the type to unsigned int.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Eddie Cai <eddie.cai.linux@gmail.com>
Cc: Jagan Teki <jteki@openedev.com>
Cc: York Sun <york.sun@nxp.com>
Cc: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Tom Rini <trini@konsulko.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

V2: Add more commit log, add Simon's review tag.

 include/asm-generic/global_data.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tom Rini May 12, 2017, 5:23 p.m. UTC | #1 
On Tue, May 09, 2017 at 10:32:03AM +0800, Peng Fan wrote:

> Change type of timebase_l/h to unsigned int.
> >From lib/time.c: ((uint64_t)gd->timebase_h << 32) | gd->timebase_l;
> This piece code is based on that timebase_h and timebase_l are
> 32bits width, so change the type to unsigned int.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Eddie Cai <eddie.cai.linux@gmail.com>
> Cc: Jagan Teki <jteki@openedev.com>
> Cc: York Sun <york.sun@nxp.com>
> Cc: "Robert P. J. Day" <rpjday@crashcourse.ca>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Tom Rini <trini@konsulko.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h
index 1a77c98..51838b5 100644
--- a/include/asm-generic/global_data.h
+++ b/include/asm-generic/global_data.h
@@ -83,8 +83,8 @@  typedef struct global_data {
 #ifdef CONFIG_SYS_I2C_MXC
 	void *srdata[10];
 #endif
-	unsigned long timebase_h;
-	unsigned long timebase_l;
+	unsigned int timebase_h;
+	unsigned int timebase_l;
 #ifdef CONFIG_SYS_MALLOC_F_LEN
 	unsigned long malloc_base;	/* base address of early malloc() */
 	unsigned long malloc_limit;	/* limit address */