diff mbox

[10/11] register: display register prefix (name) since it is available

Message ID 20170508233918.9043-11-f4bug@amsat.org
State Accepted, archived
Headers show

Commit Message

Philippe Mathieu-Daudé May 8, 2017, 11:39 p.m. UTC 
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/core/register.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Alistair Francis May 9, 2017, 12:05 a.m. UTC | #1 
On Mon, May 8, 2017 at 4:39 PM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>

Thanks,

Alistair

> ---
>  hw/core/register.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/core/register.c b/hw/core/register.c
> index dc335a79a9..b5988c9cc3 100644
> --- a/hw/core/register.c
> +++ b/hw/core/register.c
> @@ -195,8 +195,8 @@ void register_write_memory(void *opaque, hwaddr addr,
>      }
>
>      if (!reg) {
> -        qemu_log_mask(LOG_GUEST_ERROR, "Write to unimplemented register at " \
> -                      "address: %#" PRIx64 "\n", addr);
> +        qemu_log_mask(LOG_GUEST_ERROR, "%s: write to unimplemented register " \
> +                      "at address: %#" PRIx64 "\n", reg_array->prefix, addr);
>          return;
>      }
>
> @@ -224,8 +224,8 @@ uint64_t register_read_memory(void *opaque, hwaddr addr,
>      }
>
>      if (!reg) {
> -        qemu_log_mask(LOG_GUEST_ERROR, "Read to unimplemented register at " \
> -                      "address: %#" PRIx64 "\n", addr);
> +        qemu_log_mask(LOG_GUEST_ERROR, "%s:  read to unimplemented register " \
> +                      "at address: %#" PRIx64 "\n", reg_array->prefix, addr);
>          return 0;
>      }
>
> --
> 2.11.0
>
>
Michael Tokarev May 23, 2017, 2:56 p.m. UTC | #2 
applied to -trivial, thanks!

/mjt
diff mbox

Patch

diff --git a/hw/core/register.c b/hw/core/register.c
index dc335a79a9..b5988c9cc3 100644
--- a/hw/core/register.c
+++ b/hw/core/register.c
@@ -195,8 +195,8 @@  void register_write_memory(void *opaque, hwaddr addr,
     }
 
     if (!reg) {
-        qemu_log_mask(LOG_GUEST_ERROR, "Write to unimplemented register at " \
-                      "address: %#" PRIx64 "\n", addr);
+        qemu_log_mask(LOG_GUEST_ERROR, "%s: write to unimplemented register " \
+                      "at address: %#" PRIx64 "\n", reg_array->prefix, addr);
         return;
     }
 
@@ -224,8 +224,8 @@  uint64_t register_read_memory(void *opaque, hwaddr addr,
     }
 
     if (!reg) {
-        qemu_log_mask(LOG_GUEST_ERROR, "Read to unimplemented register at " \
-                      "address: %#" PRIx64 "\n", addr);
+        qemu_log_mask(LOG_GUEST_ERROR, "%s:  read to unimplemented register " \
+                      "at address: %#" PRIx64 "\n", reg_array->prefix, addr);
         return 0;
     }