Message ID | 9932ee63-f766-49ce-d760-9a0bd06f0657@users.sourceforge.net |
---|---|
State | Rejected, archived |
Delegated to: | David Miller |
Headers | show |
Am 08.05.2017 um 19:29 schrieb SF Markus Elfring: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Mon, 8 May 2017 19:21:27 +0200 > > A bit of data was put into a sequence by separate function calls. > Print the same data together with adjusted seq_printf() calls instead. Sorry, i'm not happy with this patch. It doesn't increase readabilityand mixes the output of multiple lines. The only benefit is a little bit higher performance. But for debugfs this won't be necessary. Stefan > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/net/ethernet/qualcomm/qca_debug.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) >
> The only benefit is a little bit higher performance. I would prefer such a small code reduction. I am not so concerned about an other readability impression at this place. > But for debugfs this won't be necessary. I would appreciate also another improvement there. Regards, Markus
diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c index d145df98feff..27b5c1dd27d0 100644 --- a/drivers/net/ethernet/qualcomm/qca_debug.c +++ b/drivers/net/ethernet/qualcomm/qca_debug.c @@ -81,11 +81,7 @@ qcaspi_info_show(struct seq_file *s, void *what) else seq_puts(s, "in use"); - seq_puts(s, "\n"); - - seq_printf(s, "TX ring size : %u\n", - qca->txr.size); - + seq_printf(s, "\nTX ring size : %u\n", qca->txr.size); seq_printf(s, "Sync state : %u (", (unsigned int)qca->sync); switch (qca->sync) { @@ -102,10 +98,8 @@ qcaspi_info_show(struct seq_file *s, void *what) seq_puts(s, "INVALID"); break; } - seq_puts(s, ")\n"); - seq_printf(s, "IRQ : %d\n", - qca->spi_dev->irq); + seq_printf(s, ")\nIRQ : %d\n", qca->spi_dev->irq); seq_printf(s, "INTR REQ : %u\n", qca->intr_req); seq_printf(s, "INTR SVC : %u\n",