From patchwork Fri Dec 17 19:44:58 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Mason X-Patchwork-Id: 75969 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7D489B6F2B for ; Sat, 18 Dec 2010 06:45:30 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754764Ab0LQTpI (ORCPT ); Fri, 17 Dec 2010 14:45:08 -0500 Received: from mail-yw0-f46.google.com ([209.85.213.46]:63825 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752959Ab0LQTpG (ORCPT ); Fri, 17 Dec 2010 14:45:06 -0500 Received: by ywl5 with SMTP id 5so494706ywl.19 for ; Fri, 17 Dec 2010 11:45:05 -0800 (PST) Received: by 10.150.138.17 with SMTP id l17mr3382515ybd.82.1292615105494; Fri, 17 Dec 2010 11:45:05 -0800 (PST) Received: from arkham.kudzu.us (cpe-72-177-2-76.austin.res.rr.com [72.177.2.76]) by mx.google.com with ESMTPS id v6sm5754312ybk.20.2010.12.17.11.45.01 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 17 Dec 2010 11:45:04 -0800 (PST) Received: by arkham.kudzu.us (sSMTP sendmail emulation); Fri, 17 Dec 2010 13:44:58 -0600 Date: Fri, 17 Dec 2010 13:44:58 -0600 From: Jon Mason To: Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Ramkrishna Vepa Subject: "x86: allocate space within a region top-down" causes bar0 access issue Message-ID: <20101217194457.GA4470@exar.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The following patch is causing problem with the vxge driver/adapter on HP x86-64 systems. Reads to bar0 to return 0xffffffffffffffff instead of their intended value. This prevents the vxge module from loading by failing sanity checks in the driver for certain values in bar0. We are not seeing any issues with this patch on non-HP systems in our lab. Can this patch be removed from 2.6.37 until a better solution can be found? Thanks, Jon commit 1af3c2e45e7a641e774bbb84fa428f2f0bf2d9c9 Author: Bjorn Helgaas Date: Tue Oct 26 15:41:54 2010 -0600 x86: allocate space within a region top-down Request that allocate_resource() use available space from high addresses first, rather than the default of using low addresses first. The most common place this makes a difference is when we move or assign new PCI device resources. Low addresses are generally scarce, so it's better to use high addresses when possible. This follows Windows practice for PCI allocation. Reference: https://bugzilla.kernel.org/show_bug.cgi?id=16228#c42 Signed-off-by: Bjorn Helgaas Signed-off-by: Jesse Barnes --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index 922b5a1..0fe76df 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -788,6 +788,7 @@ void __init setup_arch(char **cmdline_p) x86_init.oem.arch_setup(); + resource_alloc_from_bottom = 0; iomem_resource.end = (1ULL << boot_cpu_data.x86_phys_bits) - 1; setup_memory_map(); parse_setup_data();