[Testsuite,committed] Fix vector peeling test failures

Message ID	AM5PR0802MB2610577DB0F2E64E8EF4F2AA83EE0@AM5PR0802MB2610.eurprd08.prod.outlook.com
State	New
Headers	show Return-Path: <gcc-patches-return-453025-incoming=patchwork.ozlabs.org@gcc.gnu.org> DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:content-type :content-transfer-encoding:mime-version; q=dns; s=default; b=obo NoWha/rkOex/L8HM+lLTNYVnyIBoVqJhv3ygElRsNIyjbTaYKc7ztAWtddoai9tE dmv+TYLaCWxECWL1GRjeaHW3vNHnz7o+oAtG27tfncG2s7ikntVD33xaikLfnG8q iA9XxMTkxjxp928Qu82aPNM99XYWJR90jj+QReic= Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk Sender: gcc-patches-owner@gcc.gnu.org From: Wilco Dijkstra <Wilco.Dijkstra@arm.com> To: GCC Patches <gcc-patches@gcc.gnu.org> CC: nd <nd@arm.com>, Christophe Lyon <christophe.lyon@linaro.org>, "Richard Biener" <richard.guenther@gmail.com> Subject: [Testsuite, committed] Fix vector peeling test failures Date: Mon, 8 May 2017 12:41:33 +0000 Message-ID: <AM5PR0802MB2610577DB0F2E64E8EF4F2AA83EE0@AM5PR0802MB2610.eurprd08.prod.outlook.com> nodisclaimer: True spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0

Message ID

AM5PR0802MB2610577DB0F2E64E8EF4F2AA83EE0@AM5PR0802MB2610.eurprd08.prod.outlook.com

State

New

Headers

DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id
	:list-unsubscribe:list-archive:list-post:list-help:sender:from
	:to:cc:subject:date:message-id:content-type
	:content-transfer-encoding:mime-version; q=dns; s=default; b=obo
	NoWha/rkOex/L8HM+lLTNYVnyIBoVqJhv3ygElRsNIyjbTaYKc7ztAWtddoai9tE
	dmv+TYLaCWxECWL1GRjeaHW3vNHnz7o+oAtG27tfncG2s7ikntVD33xaikLfnG8q
	iA9XxMTkxjxp928Qu82aPNM99XYWJR90jj+QReic=
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
Sender: gcc-patches-owner@gcc.gnu.org
From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
CC: nd <nd@arm.com>, Christophe Lyon <christophe.lyon@linaro.org>,
	"Richard Biener" <richard.guenther@gmail.com>
Subject: [Testsuite, committed] Fix vector peeling test failures
Date: Mon, 8 May 2017 12:41:33 +0000
Message-ID: <AM5PR0802MB2610577DB0F2E64E8EF4F2AA83EE0@AM5PR0802MB2610.eurprd08.prod.outlook.com>
nodisclaimer: True
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2017 12:41:33.2194
	(UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2611

Commit Message

Wilco Dijkstra May 8, 2017, 12:41 p.m. UTC

This fixes a few failures on ARM and AArch64 due to a recent change in
alignment peeling by switching the vector cost model off
(https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00407.html).

Tested on AArch64, ARM and x64 - committed as obvious.

ChangeLog: 
2017-05-08  Wilco Dijkstra  <wdijkstr@arm.com>

	* testsuite/gcc.dg/vect/vect-44.c: Add -fno-vect-cost-model.
	* gcc/testsuite/gcc.dg/vect/vect-50.c: Likewise.
--

Comments

Li, Pan2 via Gcc-patches May 8, 2017, 1:49 p.m. UTC | #1

On Mon, May 8, 2017 at 2:41 PM, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
> This fixes a few failures on ARM and AArch64 due to a recent change in
> alignment peeling by switching the vector cost model off
> (https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00407.html).
>
> Tested on AArch64, ARM and x64 - committed as obvious.

Thanks.  Note that I'm not sure what -fno-vect-cost-model actually means when
peeling for alignment, so this fix might not "prevail".

Richard.

> ChangeLog:
> 2017-05-08  Wilco Dijkstra  <wdijkstr@arm.com>
>
>         * testsuite/gcc.dg/vect/vect-44.c: Add -fno-vect-cost-model.
>         * gcc/testsuite/gcc.dg/vect/vect-50.c: Likewise.
> --
>
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-44.c b/gcc/testsuite/gcc.dg/vect/vect-44.c
> index 186f9cfc9e26d6eb53514dec0fac176d696ec578..fbc593572429422c8e527c5e5559c515efd38aa6 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-44.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-44.c
> @@ -1,4 +1,5 @@
>  /* { dg-require-effective-target vect_float } */
> +/* { dg-options "-fno-vect-cost-model" } */
>
>  #include <stdarg.h>
>  #include "tree-vect.h"
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-50.c b/gcc/testsuite/gcc.dg/vect/vect-50.c
> index 78bfd8d3920445fe51c7393a82870ea85f62bb55..0d5febc165ee3bf3b7b595237168d9d4b9604d4b 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-50.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-50.c
> @@ -1,4 +1,5 @@
>  /* { dg-require-effective-target vect_float } */
> +/* { dg-options "-fno-vect-cost-model" } */
>
>  #include <stdarg.h>
>  #include "tree-vect.h"

Richard Biener May 9, 2017, 8:05 a.m. UTC | #2

On Mon, May 8, 2017 at 3:49 PM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Mon, May 8, 2017 at 2:41 PM, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
>> This fixes a few failures on ARM and AArch64 due to a recent change in
>> alignment peeling by switching the vector cost model off
>> (https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00407.html).
>>
>> Tested on AArch64, ARM and x64 - committed as obvious.
>
> Thanks.  Note that I'm not sure what -fno-vect-cost-model actually means when
> peeling for alignment, so this fix might not "prevail".

This broke the testcases -- you have to use dg-additional-options,
otherwise I now get

gcc.dg/vect/vect-44.c -flto -ffat-lto-objects : dump file does not exist
UNRESOLVED: gcc.dg/vect/vect-44.c -flto -ffat-lto-objects
scan-tree-dump-times vect "Alignment of access forced using peeling" 1
...

fixing that now.

Richard.

> Richard.
>
>> ChangeLog:
>> 2017-05-08  Wilco Dijkstra  <wdijkstr@arm.com>
>>
>>         * testsuite/gcc.dg/vect/vect-44.c: Add -fno-vect-cost-model.
>>         * gcc/testsuite/gcc.dg/vect/vect-50.c: Likewise.
>> --
>>
>> diff --git a/gcc/testsuite/gcc.dg/vect/vect-44.c b/gcc/testsuite/gcc.dg/vect/vect-44.c
>> index 186f9cfc9e26d6eb53514dec0fac176d696ec578..fbc593572429422c8e527c5e5559c515efd38aa6 100644
>> --- a/gcc/testsuite/gcc.dg/vect/vect-44.c
>> +++ b/gcc/testsuite/gcc.dg/vect/vect-44.c
>> @@ -1,4 +1,5 @@
>>  /* { dg-require-effective-target vect_float } */
>> +/* { dg-options "-fno-vect-cost-model" } */
>>
>>  #include <stdarg.h>
>>  #include "tree-vect.h"
>> diff --git a/gcc/testsuite/gcc.dg/vect/vect-50.c b/gcc/testsuite/gcc.dg/vect/vect-50.c
>> index 78bfd8d3920445fe51c7393a82870ea85f62bb55..0d5febc165ee3bf3b7b595237168d9d4b9604d4b 100644
>> --- a/gcc/testsuite/gcc.dg/vect/vect-50.c
>> +++ b/gcc/testsuite/gcc.dg/vect/vect-50.c
>> @@ -1,4 +1,5 @@
>>  /* { dg-require-effective-target vect_float } */
>> +/* { dg-options "-fno-vect-cost-model" } */
>>
>>  #include <stdarg.h>
>>  #include "tree-vect.h"

Richard Biener May 9, 2017, 8:06 a.m. UTC | #3

On Tue, May 9, 2017 at 10:05 AM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Mon, May 8, 2017 at 3:49 PM, Richard Biener
> <richard.guenther@gmail.com> wrote:
>> On Mon, May 8, 2017 at 2:41 PM, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
>>> This fixes a few failures on ARM and AArch64 due to a recent change in
>>> alignment peeling by switching the vector cost model off
>>> (https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00407.html).
>>>
>>> Tested on AArch64, ARM and x64 - committed as obvious.
>>
>> Thanks.  Note that I'm not sure what -fno-vect-cost-model actually means when
>> peeling for alignment, so this fix might not "prevail".
>
> This broke the testcases -- you have to use dg-additional-options,
> otherwise I now get
>
> gcc.dg/vect/vect-44.c -flto -ffat-lto-objects : dump file does not exist
> UNRESOLVED: gcc.dg/vect/vect-44.c -flto -ffat-lto-objects
> scan-tree-dump-times vect "Alignment of access forced using peeling" 1
> ...
>
> fixing that now.

Oh, and -fno-vect-cost-model is the default anyway so your patch
couldn't have fixed anything.

Thus reverting instead.

Richard.

> Richard.
>
>> Richard.
>>
>>> ChangeLog:
>>> 2017-05-08  Wilco Dijkstra  <wdijkstr@arm.com>
>>>
>>>         * testsuite/gcc.dg/vect/vect-44.c: Add -fno-vect-cost-model.
>>>         * gcc/testsuite/gcc.dg/vect/vect-50.c: Likewise.
>>> --
>>>
>>> diff --git a/gcc/testsuite/gcc.dg/vect/vect-44.c b/gcc/testsuite/gcc.dg/vect/vect-44.c
>>> index 186f9cfc9e26d6eb53514dec0fac176d696ec578..fbc593572429422c8e527c5e5559c515efd38aa6 100644
>>> --- a/gcc/testsuite/gcc.dg/vect/vect-44.c
>>> +++ b/gcc/testsuite/gcc.dg/vect/vect-44.c
>>> @@ -1,4 +1,5 @@
>>>  /* { dg-require-effective-target vect_float } */
>>> +/* { dg-options "-fno-vect-cost-model" } */
>>>
>>>  #include <stdarg.h>
>>>  #include "tree-vect.h"
>>> diff --git a/gcc/testsuite/gcc.dg/vect/vect-50.c b/gcc/testsuite/gcc.dg/vect/vect-50.c
>>> index 78bfd8d3920445fe51c7393a82870ea85f62bb55..0d5febc165ee3bf3b7b595237168d9d4b9604d4b 100644
>>> --- a/gcc/testsuite/gcc.dg/vect/vect-50.c
>>> +++ b/gcc/testsuite/gcc.dg/vect/vect-50.c
>>> @@ -1,4 +1,5 @@
>>>  /* { dg-require-effective-target vect_float } */
>>> +/* { dg-options "-fno-vect-cost-model" } */
>>>
>>>  #include <stdarg.h>
>>>  #include "tree-vect.h"

diff --git a/gcc/testsuite/gcc.dg/vect/vect-44.c b/gcc/testsuite/gcc.dg/vect/vect-44.c
index 186f9cfc9e26d6eb53514dec0fac176d696ec578..fbc593572429422c8e527c5e5559c515efd38aa6 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-44.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-44.c
@@ -1,4 +1,5 @@ 
 /* { dg-require-effective-target vect_float } */
+/* { dg-options "-fno-vect-cost-model" } */
 
 #include <stdarg.h>
 #include "tree-vect.h"
diff --git a/gcc/testsuite/gcc.dg/vect/vect-50.c b/gcc/testsuite/gcc.dg/vect/vect-50.c
index 78bfd8d3920445fe51c7393a82870ea85f62bb55..0d5febc165ee3bf3b7b595237168d9d4b9604d4b 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-50.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-50.c
@@ -1,4 +1,5 @@ 
 /* { dg-require-effective-target vect_float } */
+/* { dg-options "-fno-vect-cost-model" } */
 
 #include <stdarg.h>
 #include "tree-vect.h"