diff mbox

gpio: mcp23s08: Use seq_putc() in mcp23s08_dbg_show()

Message ID 78956b0e-7f06-487c-cd11-fea77a65e66a@users.sourceforge.net
State New
Headers show

Commit Message

SF Markus Elfring May 8, 2017, 10:50 a.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 8 May 2017 12:44:36 +0200

A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/gpio/gpio-mcp23s08.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij May 11, 2017, 2:33 p.m. UTC | #1 
On Mon, May 8, 2017 at 12:50 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 8 May 2017 12:44:36 +0200
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

I can't change stuff around this driver right now as it is being
rewritten.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/gpio/gpio-mcp23s08.c b/drivers/gpio/gpio-mcp23s08.c
index 2a57d024481d..51dff7e95a9e 100644
--- a/drivers/gpio/gpio-mcp23s08.c
+++ b/drivers/gpio/gpio-mcp23s08.c
@@ -519,7 +519,7 @@  static void mcp23s08_dbg_show(struct seq_file *s, struct gpio_chip *chip)
 			(mcp->cache[MCP_GPIO] & mask) ? "hi" : "lo",
 			(mcp->cache[MCP_GPPU] & mask) ? "up" : "  ");
 		/* NOTE:  ignoring the irq-related registers */
-		seq_puts(s, "\n");
+		seq_putc(s, '\n');
 	}
 done:
 	mutex_unlock(&mcp->lock);