diff mbox

[V2] dmi: dmicheck: fix a typo in a type 15's error message

Message ID 1494026820-20585-1-git-send-email-alex.hung@canonical.com
State Accepted
Headers show

Commit Message

Alex Hung May 5, 2017, 11:27 p.m. UTC 
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/dmi/dmicheck/dmicheck.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Colin Ian King May 5, 2017, 11:44 p.m. UTC | #1 
On 06/05/17 00:27, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 77bfda6..2665ea7 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1278,7 +1278,7 @@ static void dmicheck_entry(fwts_framework *fw,
>  			if (!((val <= 0x04) || (val >= 0x80))) {
>  				fwts_failed(fw, LOG_LEVEL_HIGH, DMI_VALUE_OUT_OF_RANGE,
>  					"Out of range value 0x%2.2" PRIx8 " "
> -					"(range allowed 0x00..0x01, "
> +					"(range allowed 0x00..0x04, "
>  					"0x80..0xff) while accessing entry '%s' @ "
>  					"0x%8.8" PRIx32 ", field '%s', offset 0x%2.2x",
>  					val, table, addr, "Access Method", 0x0a);
> 

Thanks Alex,

Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu May 10, 2017, 8:17 a.m. UTC | #2 
On 05/06/2017 07:27 AM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 77bfda6..2665ea7 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1278,7 +1278,7 @@ static void dmicheck_entry(fwts_framework *fw,
>  			if (!((val <= 0x04) || (val >= 0x80))) {
>  				fwts_failed(fw, LOG_LEVEL_HIGH, DMI_VALUE_OUT_OF_RANGE,
>  					"Out of range value 0x%2.2" PRIx8 " "
> -					"(range allowed 0x00..0x01, "
> +					"(range allowed 0x00..0x04, "
>  					"0x80..0xff) while accessing entry '%s' @ "
>  					"0x%8.8" PRIx32 ", field '%s', offset 0x%2.2x",
>  					val, table, addr, "Access Method", 0x0a);
>


Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
index 77bfda6..2665ea7 100644
--- a/src/dmi/dmicheck/dmicheck.c
+++ b/src/dmi/dmicheck/dmicheck.c
@@ -1278,7 +1278,7 @@  static void dmicheck_entry(fwts_framework *fw,
 			if (!((val <= 0x04) || (val >= 0x80))) {
 				fwts_failed(fw, LOG_LEVEL_HIGH, DMI_VALUE_OUT_OF_RANGE,
 					"Out of range value 0x%2.2" PRIx8 " "
-					"(range allowed 0x00..0x01, "
+					"(range allowed 0x00..0x04, "
 					"0x80..0xff) while accessing entry '%s' @ "
 					"0x%8.8" PRIx32 ", field '%s', offset 0x%2.2x",
 					val, table, addr, "Access Method", 0x0a);