| Message ID | 20170505161716.6752-1-vdronov@redhat.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Vladis Dronov <vdronov@redhat.com> Date: Fri, 5 May 2017 18:17:16 +0200 > Move misplaced EXPORT_SYMBOL_GPL(ping_hash) to a proper place. > > Signed-off-by: Vladis Dronov <vdronov@redhat.com> Please use a proper subject line with an appropriate subsystem prefix. Also you must indicate the intended target tree (net or net-next) in the [] brackets. For example: [PATCH net] ipv4: Fix misplaced EXPORT_SYMBOL_GPL ...
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index ccfbce1..19f0b7b 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/ping.c @@ -71,7 +71,6 @@ static inline u32 ping_hashfn(const struct net *net, u32 num, u32 mask) pr_debug("hash(%u) = %u\n", num, res); return res; } -EXPORT_SYMBOL_GPL(ping_hash); static inline struct hlist_nulls_head *ping_hashslot(struct ping_table *table, struct net *net, unsigned int num) @@ -152,6 +151,7 @@ int ping_hash(struct sock *sk) return 0; } +EXPORT_SYMBOL_GPL(ping_hash); void ping_unhash(struct sock *sk) {
Move misplaced EXPORT_SYMBOL_GPL(ping_hash) to a proper place. Signed-off-by: Vladis Dronov <vdronov@redhat.com> --- Actually, this is so small and unimportant (it just hurts my perfectionism), so does not worth a separate patch. Please, feel free to make it a part of some patch of yours. net/ipv4/ping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)