| Message ID | 20170504065209.26106-4-sudarsana.kalluru@cavium.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wJQhX5Lvcz9rxw for <patchwork-incoming@ozlabs.org>; Thu, 4 May 2017 16:53:00 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="T2JgAby5"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbdEDGw7 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Thu, 4 May 2017 02:52:59 -0400 Received: from mail-sn1nam02on0078.outbound.protection.outlook.com ([104.47.36.78]:9856 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751400AbdEDGwz (ORCPT <rfc822;netdev@vger.kernel.org>); Thu, 4 May 2017 02:52:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Wndjnv5whhc8lA5+q9Jnnsr5enabrVTzYBsdykd3uKo=; b=T2JgAby5y1USpdQPdJmoWGXNkmr7prAuWHqFmI2Yod1ahaN2xDVmHO125U/xhPS2qgj6o73S7nTE3bOVKoPt/hvdovg6OQhmxYxXSrUP4RgkAXjpz5euR49uMiQLF/jv1OIhRuQOycH9hEyFqpbOrJ7H5sisE8DUs/jsOMJN34A= Received: from SN1PR0701CA0073.namprd07.prod.outlook.com (10.163.126.41) by CY1PR07MB2521.namprd07.prod.outlook.com (10.167.16.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1061.12; Thu, 4 May 2017 06:52:40 +0000 Received: from BY2FFO11FD021.protection.gbl (2a01:111:f400:7c0c::193) by SN1PR0701CA0073.outlook.office365.com (2a01:111:e400:52fd::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11 via Frontend Transport; Thu, 4 May 2017 06:52:39 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BY2FFO11FD021.mail.protection.outlook.com (10.1.15.210) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1047.9 via Frontend Transport; Thu, 4 May 2017 06:52:39 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 3 May 2017 23:52:32 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v446qIJp026157; Wed, 3 May 2017 23:52:18 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v446qIOk026156; Wed, 3 May 2017 23:52:18 -0700 From: Sudarsana Reddy Kalluru <sudarsana.kalluru@cavium.com> To: <davem@davemloft.net> CC: <netdev@vger.kernel.org>, <Yuval.Mintz@cavium.com> Subject: [PATCH net 3/3] qede: Fix possible misconfiguration of advertised autoneg value. Date: Wed, 3 May 2017 23:52:09 -0700 Message-ID: <20170504065209.26106-4-sudarsana.kalluru@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170504065209.26106-1-sudarsana.kalluru@cavium.com> References: <20170504065209.26106-1-sudarsana.kalluru@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39840400002)(39400400002)(39850400002)(39450400003)(39410400002)(2980300002)(428002)(189002)(199003)(9170700003)(101416001)(2906002)(8936002)(81166006)(54906002)(305945005)(42186005)(80596001)(8676002)(50986999)(76176999)(47776003)(50226002)(86362001)(110136004)(38730400002)(107886003)(189998001)(36756003)(5660300001)(1076002)(2351001)(50466002)(33646002)(4326008)(6666003)(6916009)(2950100002)(356003)(87636003)(5003940100001)(48376002)(478600001)(106466001)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2521; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD021; 1:FcYYxLLani0jloQDJAuhAlDI97YRdrgzmjXcUMtzyMcXmowH7L8X9LU56852TChad6MtMj/rULzkqIWflKXvocWNeJt4Axpc/SCTIJKtjjQr1yqOgQVlW0Tg9ktj2ejfI36pFU2aGA3skq/PPMiT0SF+wk3/by9vZuDrtvvwtkmnAQmzimHBgd4y4dg2xC8WHNdROkuXVdEoaoBRWM1CuOfbTFPqEqAPkz6gp12v9WyVsY90Fd6YhU2Ifj6lEY/d8qd3MwLS+qlPERkDqajxqunYXFZTHHl0eUSBt6FWjqa5fyY5xLBHQLvPblA0ODywSoTJPyO8q5KD9WkgQbO3oA2h/TKKGQVCiAIdLSOjqbx0D3T1W+kfWmo2cgYBGush9fUUn6Mbm9sSQVEHdqEFR8sTs/wwuAA51MGNInRgnR6paxBEZid+xs9L4OH1XTmPWZ0gPzh2CT0q5+WrhXBMbY1BtLyjORBB4IGIhQRBfzAfHxRVRRQbjRiI/3bam8UODt/6lUXmlYEvyCT7pAGPt+5No6gDOG0fEivHRQI8Bs6j6yj5oX6B6dPfXLuWzI4UVdUU5UK9h08TxxtvZ53Ghw== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ce0961fb-dfa4-476f-295c-08d492ba280b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:CY1PR07MB2521; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 3:ue7uRWKYVmEV4SJbxrP+EurNC0aWzB2ZQO9/mwjriNZa0/r1Z+OQBfo45jPu2njvwTdGgVMfCBH/gqMBE7AHIOROOro+NhiMoR6QmNaE/qmDjc3dyqTcWUVXgByB4G8ADpuaXz9RNIgKjdIzNesUaEGHttUEnKJw5rvLR7TbCBeQPoHKAX4U6XRDv8vOkSOw/ZX+JzouxZLXkK1EF6c7pIWFXLratdr5DK65cqrSrDkz/4JOkHxsYlzVRDWLy5FoPaUumLtkIJatsJZBvM//j2fU8VxqqEMQHOb2zMMwB/FZdwVEjPvYatfqitZmQtf4tuhdXh3xdu0T59n+T/FJUxZZ0ZYVidNnlJYBRi8eqaZZEaGbvA8zuhFAJx+yCPiIhzfu84E7XSHYnEqQ39itFbe+pVmX4E+7vbZ63e7zemHgV6So58teY4EGfHhZVYbDA9Hobp09SiJzi5VJCCBLnevJfObF4OSj/QU4QIyd0gR+v0JB+Dx5fDUQ6vZhBxgM X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 25:jQ3nqOa/YTPjLa+S6FdpkLGkxH5vtHOvZXXLqzNPiW9phHDWSb1i3+PrgHJh6uGaVRYhQjATy1dpLIdvOn1XA8CYwjbv9uBdXbehtP+LlzXXsKTfKg6ewoIvIEbwG6c7wi+ecTdJxY13Dd+4rGOYJzJzcH79dNSr1TjrbaLztHsBfsNgvxJC1ob3xIUE9ZsRQ4xM1W+B+y+c5hOSUp8Naz+6gy33bjPAEZQd+fyTAzOndm7SkmGeSdSpcL/EvPXtvQzEx+EKx7iFsArC0RfZi5wMQrfIQT9u3oER4p89F86HJ/1t0ajl1zDcwWC76oGOB+LPgnpva+caiT2tzeJUKVwyYbYvQyVX8nPFb3GHYkT7LtBGR7i1YPfiQj2vziTwUah4KLxn3SlpmA7L+F3AkxGBKr9LuyW5W6HZHhAYwWrPDXy62LRg6wyzVa9nXVAFrGtVusd/02gEVJNGMm7ETg==; 31:91L8dC1FZ9cv4G60yDXlDNVhmRN3ihVR1Hk+zhafEV8goh3eukg+tTRCWreM9SkMBKzUwfD2iivH0hgabXfrdkmPePZbvEV7KT+VeyxMd366h7d1WELF66W5crpsnEk2j0E75lG7KlzRknW9KBCleGYHcxHfCnsqoZXTHJJU0KUvrpottKjrJigylFDvqn1UA+KccekrV1XH/4VhZSJs1Pe+rVGWOww4UOg/w+3hftZG5YuwZY6pCMelB/Y0x84m/FCtzTRKGdNtWlsFuTXTFUEVHFc4u9PLXPCFpdFDIM0= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 20:DSkRAPUJ0YpTY++c9eq6YX+tkC7KKi69K+k6P6AaQeq5XG2uH5fCv8OQXdUK9Up8imfkYjLiUMNy/pDV5uGM9otFgHh6/B9syRBIbOrMhJv73y22nWtZ0lifZts0eirRfjse0nXZOp/FNPsBLUO4NVvo8xWItPNKPowshfOhawvhkguaPgGBXEhK6aiuOw4dk4R9bBfo0cb8V4muUOp0f3QustaM1tlVKLLlB9J12wK0Jqg3MaEvBz9NHsfI6rwFCB1K+P4CZtczzs91uavG+j5ZLIUUC/qKj4gT2wvedupYnPH9wkjwFMnymh9acd9XEwTh7lWTdOu7UGIOTTrx+SAkQYOkUpVprqjHuNvIwnwxGi97UzAqCClJDS0YejbQ2SKKsDaPi9KFUcRbAlc4JUPuoFfkUDjiKUhpHr6Q27IlxAEWNIVUL/hpMuFR9/ofELzpTnK3gVKSDHiC8a8CEfnCVfoWmqJwWTdgLAhyMOdTsk8fFAeDnQhNplLi+pvb X-Microsoft-Antispam-PRVS: <CY1PR07MB2521FE1EB822F903246B053D8AEA0@CY1PR07MB2521.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(13015025)(13017025)(5005006)(8121501046)(13023025)(13024025)(13018025)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123560025)(20161123555025)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148); SRVR:CY1PR07MB2521; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2521; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 4:gAEX+Pg30Akj/gEi7M+5/OTwvoLue+/UDPAHc9v43lpYltSTFgbEdkceDfll8b8wAgt2e96bcZxQ/sefHJWIIHV3rCIexnaRCfc0Yn3BGJDpJod5AvMj2GyiKaTq+lvmTaegDcdx48CdCMCffSBMpFiBaWhsjAkzXsb3sYE7XE0ZwfU/OToSuziBJI0fPynuiefAoRMv6UkKcFiM8SmmmtJNc12HgN/9YSe8nJkpvI3QvjuuZ0602arNKDZqIrV2hABvb5AmQfthF3wbYFGEEXSrZevO6Df8HO+dbcbidhweEI0ZmkRlqAwPQLCoq4PlndFgtySDKOBsAA8obLch8mzcf1oIVzz3oxF+k0JfZop8nOSdepU/gRorpX5R2tKeSOgj51IF+hYNUw+BcQNXpZ8JO/GhSMLvWX5EnzbjVE5rvDALz3mjJUgQxd6kQKj8zoU3EhrwZ8EgW/xXVpuyuBXkzcfXaymYJGVGZrsBgwvoF7qEYXM0mpjGJV6n69jiaLAOaqp2aMxWNL87bk2l8b0dX4JKl0pKHDC9whj7YSxdlLq/gbzu+NUQnjt17e6SmMQ9i/hd3fOqa66h9yQGbR7GCZ5CaRrTr+Ev3bdHUxb4wd5yOiZDUvqBLS1L74sr9zGBEhHxAsyVnUq7ROxinJVKWtOgJcbRFrK2KFfpva86Zip4DZ+LjyGHlH/topnweZMkbwVFzEGAoPqcFBQxw3/62cFHrFp10/kcBVZVvow+aSs4poRsEU6w9F0IIQbCdj1OYY2L0epCfZ1o+6SgjdAqsUt2CR3CvMWaw6JWa3vuFe3DBLLhaiDfJpnys1UrPudngZEyldNJqmBqix8NrzOlkLgqWYYK2Tw4ZLNutnYZz4hRSr9v9WkmEVie8+nF X-Forefront-PRVS: 02973C87BC X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2521; 23:fd2TN+h71fEAZWBJLkLW+S65pq//el1jm/nz2o+dj?= =?us-ascii?Q?q8uXuugQAyXRKB+6yMqzpXq6DF0MlzPKJK3fR17mnqIiU/vgNgkJENG30pH0?= =?us-ascii?Q?J3kJ0tPp8N4bMUNPWwAhjPKJUNB5OwAO0f5lt2wmY2630b49auxIjinpPAf1?= =?us-ascii?Q?9967jS97QN3J3W4xx2H2WoZa9VCQu0NGUAoe4fuA83xgMHUGpdssQYmCzrSh?= =?us-ascii?Q?jRFerCv00o0A5SOJmpe7S7H76c7apepaFz/DCWkow6yMMaY8iFz8Y9odmMRQ?= =?us-ascii?Q?CvcEHpAVdHqqzZHK1DRh9HeRHdszAQAdBjtEiPwEksMSqxQLWLw15iPjwQIL?= =?us-ascii?Q?q8sQ9KzzHRtF7wz+SfEMxHIDUf3BeFJS/MU6YvU14dcEg6gfn5sedCu2lwa8?= =?us-ascii?Q?HINKBhu1ug1rg1RuMx8tqZ+CDwy0efkmjQxsjWs5ziQxaCCliHsFnqJ7AoSw?= =?us-ascii?Q?O4v6eZ7hkyG5MT9xB3V3Y+Ochxhu/Y8SkOqH4As6I416KfDAaJhd7OolbZNz?= =?us-ascii?Q?h/aYQfVS6veAzaaiviHJ0AHDHqSX6qz8CBrvPneYHQOaeQd8r6ztFIni9BR3?= =?us-ascii?Q?AGyaeoy8QZohwoQJ9P9eYBJYstTwh7axUjt5AP44p/5nzopTNkXh+DJOreZc?= =?us-ascii?Q?SE+Q6Rrfmz234lF8GVnwm+t6toktOwt8OpBGdBFnoLg50PZM5mSet6OeGCsR?= =?us-ascii?Q?JrtpHL1XDleyp8xpyAum+LlN+Lttv4ND7xdGDRVBudrL4TP+zWZ+zp+AgxYz?= =?us-ascii?Q?NZl8gHUMM0id+2QBQE+gcs2MxVLECSb+Y5KhKRUMQkRjmliUHawQmO33uHeI?= =?us-ascii?Q?Z0pe4+m/e8yKRc/A7AtnLlBPgazsvGcUTKcDqVI9OuSROzsoK1T1sAEceYBX?= =?us-ascii?Q?oOFGQHd4aON1GSmSGOeR1R31QFPTGX/OurgERo6jO6bTX84tY1RkG4nHvUuq?= =?us-ascii?Q?k01MQ+jkGGNjEdfH5QjDG0sGVKN96VCfIQuQOh+iHVIJ84WAD01IJXJUgh/P?= =?us-ascii?Q?F22Tngk++z4fNpdPgTN+CNOO/WHPdqCFeTwiuXMDGPvOfg9WM2s4E++gZDVA?= =?us-ascii?Q?+Er8wGNpHrXIwTkcDcggQyoK02F9qo2GbxHMtmUk64ce3zhS2Ww7jLKcVrue?= =?us-ascii?Q?eMMgcTSTFX8O6QgDF+we+EPl2qDTX1O?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 6:wc8nAD17X21nIxJkAuEVZ51pgVj6MPxrJrYYAHC1G0wYmPHNDkcuyAT91pVDRlsH9BGrQwhHPQTwAEVbO1FusmXrzhUX3zjUaerw+LlrKHmGdq2mGqjHl0jHrLpzp3ictPzeQj9KbZ6VevYRmq4CxjCixHJ819z06W37388a7bZX3cVAYQsERqwHCRNqBJFWBhgCgLlmUKhA/XO0ndmDV7tstRnV+tQn5gO/5S5Hhm0meGtLbaWSyw1FX2UPTlwBjRDlc3PBtxCw9iq+JbLVQwpCVof5zTtjsKl2vrl2yDjhm33YWhjWFw8KaC0+85EGhvWsIESeFYZlgTdBp5nQhpsyShmvMcC3qf92qhe5fT5+ZgxScHxAYn5nJKXn9/QHuXCswL6u52ZbsqgAILg57McGJa+Ezthj4kxbmEib1sLPyaX2+TPtdsKo1fV6jXuLkzQT2karKbg5d4eOBRw7UDyMN0YxzUjNP0aGRbSNoICtdTvp6Put6LbrGtiaA32/6golNNC8B1uQ8qMe9OnDeA==; 5:qeVXSM0cxRwNteahurHubnUx5bB8UnSOIF6CABCRLA9HDtELfLxhGuYNm2Ux19dnb3GBOjX3S4tM5h2ims+RpiBI/wb4zvNJjjbBe6reT1l3D/0/tSijX7mjmv+mpqt9xJB3QTMntdGCMFUxDhKE+A==; 24:QH4/+tCqHLZJQzyhoH5DvQ/2POIO1akSwbKBWTNFXNoL3me/mDPreJg4JVuL+G3+u7Ybbp934hLSQw0kFZVuHcm8cTBJPPOvlyo26XW7WCE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 7:H6tAZ+mtEihJA7R5Q7jCnvk/2w1b9TJmNdZ3IKrQIK4AEWIPHHmfPgyAETZqdLFvmgAiXlWYSq/8qJizeH8a1Oa+uTZQwvuWALsKAYR4vCLT29UJYsL031+iCoXdjN0YcFVsI6lViXkoRgszctfWP/XX5aJ6/WVSxaz2dWVIHkH7NNDZ7TIvyc7YX+bVNwrcFwSed3Y6fnrPxEJum5bqF1P2XSSe5ZGSfRlGA8qIsJLVV0BfzbXl4+sEVszXzmgRjq+SdeCUPdpv85yB1Gb9CCTkK4+hq+qELVgdgtlBCsr26z55sjUzCiS1jJm7yCxjPKb9No5JJjpM/puSHWAN9w== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2017 06:52:39.7291 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2521 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c index b22753c..172b292 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c +++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c @@ -493,6 +493,11 @@ static int qede_set_link_ksettings(struct net_device *dev, params.override_flags |= QED_LINK_OVERRIDE_SPEED_ADV_SPEEDS; params.override_flags |= QED_LINK_OVERRIDE_SPEED_AUTONEG; if (base->autoneg == AUTONEG_ENABLE) { + if (!(current_link.supported_caps & QED_LM_Autoneg_BIT)) { + DP_INFO(edev, "Auto negotiation is not supported\n"); + return -EOPNOTSUPP; + } + params.autoneg = true; params.forced_speed = 0; QEDE_ETHTOOL_TO_DRV_CAPS(params.adv_speeds, cmd, advertising)
Fail the configuration of advertised speed-autoneg value if the config update is not supported. Signed-off-by: Sudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com> --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 5 +++++ 1 file changed, 5 insertions(+)