| Message ID | 20170504023416.25653-1-joel@jms.id.au |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 05/04/2017 04:34 AM, Joel Stanley wrote: > When booting we see something like this: > > aspeed-smc 1e620000.flash-controller: Using IRQ 17 > aspeed-smc 1e620000.flash-controller: DMA support disabled. > aspeed-smc 1e620000.flash-controller: mx25l25635e (32768 Kbytes) > aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000- 0x22000000 ] 32MB > aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000- 0x2a000000 ] 128MB > > The lack of space after the first hex number haunts me every time I > boot a BMC. > > With this fix we see the pleasingly symmetrical: > > aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000 - 0x22000000 ] 32MB > aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000 - 0x2a000000 ] 128MB > > Signed-off-by: Joel Stanley <joel@jms.id.au> Acked-by: Cédric Le Goater <clg@kaod.org> yes. I have changed that also in the patches sent to mainline, plus a couple of other things. I will send a refreshing patch when they are merged. Cheers, C. > --- > drivers/mtd/spi-nor/aspeed-smc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c > index 875b029198fc..23622bf62b6b 100644 > --- a/drivers/mtd/spi-nor/aspeed-smc.c > +++ b/drivers/mtd/spi-nor/aspeed-smc.c > @@ -709,7 +709,7 @@ static u32 chip_set_segment(struct aspeed_smc_chip *chip, u32 cs, u32 start, > size = end - start; > } > > - dev_info(chip->nor.dev, "CE%d window [ 0x%.8x- 0x%.8x ] %dMB", > + dev_info(chip->nor.dev, "CE%d window [ 0x%.8x - 0x%.8x ] %dMB", > cs, start, end, size >> 20); > > return size; >
On Thu, 2017-05-04 at 12:04 +0930, Joel Stanley wrote: > When booting we see something like this: > > aspeed-smc 1e620000.flash-controller: Using IRQ 17 > aspeed-smc 1e620000.flash-controller: DMA support disabled. > aspeed-smc 1e620000.flash-controller: mx25l25635e (32768 Kbytes) > aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000- 0x22000000 ] 32MB > aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000- 0x2a000000 ] 128MB > > The lack of space after the first hex number haunts me every time I > boot a BMC. > > With this fix we see the pleasingly symmetrical: > > aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000 - 0x22000000 ] 32MB > aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000 - 0x2a000000 ] 128MB > > > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > drivers/mtd/spi-nor/aspeed-smc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c > index 875b029198fc..23622bf62b6b 100644 > --- a/drivers/mtd/spi-nor/aspeed-smc.c > +++ b/drivers/mtd/spi-nor/aspeed-smc.c > @@ -709,7 +709,7 @@ static u32 chip_set_segment(struct aspeed_smc_chip *chip, u32 cs, u32 start, > > size = end - start; > > } > > > - dev_info(chip->nor.dev, "CE%d window [ 0x%.8x- 0x%.8x ] %dMB", > > + dev_info(chip->nor.dev, "CE%d window [ 0x%.8x - 0x%.8x ] %dMB", > cs, start, end, size >> 20); NAK! I want *no* spaces! Reviewed-by: Andrew Jeffery <andrew@aj.id.au> > > > return size;
On 05/04/2017 01:52 PM, Andrew Jeffery wrote: > On Thu, 2017-05-04 at 12:04 +0930, Joel Stanley wrote: >> When booting we see something like this: >> >> aspeed-smc 1e620000.flash-controller: Using IRQ 17 >> aspeed-smc 1e620000.flash-controller: DMA support disabled. >> aspeed-smc 1e620000.flash-controller: mx25l25635e (32768 Kbytes) >> aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000- 0x22000000 ] 32MB >> aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000- 0x2a000000 ] 128MB >> >> The lack of space after the first hex number haunts me every time I >> boot a BMC. >> >> With this fix we see the pleasingly symmetrical: >> >> aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000 - 0x22000000 ] 32MB >> aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000 - 0x2a000000 ] 128MB >> >>> Signed-off-by: Joel Stanley <joel@jms.id.au> >> --- >> drivers/mtd/spi-nor/aspeed-smc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c >> index 875b029198fc..23622bf62b6b 100644 >> --- a/drivers/mtd/spi-nor/aspeed-smc.c >> +++ b/drivers/mtd/spi-nor/aspeed-smc.c >> @@ -709,7 +709,7 @@ static u32 chip_set_segment(struct aspeed_smc_chip *chip, u32 cs, u32 start, >>> size = end - start; >>> } >> >>> - dev_info(chip->nor.dev, "CE%d window [ 0x%.8x- 0x%.8x ] %dMB", >>> + dev_info(chip->nor.dev, "CE%d window [ 0x%.8x - 0x%.8x ] %dMB", >> cs, start, end, size >> 20); > > NAK! I want *no* spaces! > > Reviewed-by: Andrew Jeffery <andrew@aj.id.au> ah ! as you wish, I have no strong feeling on the format :) Cheers, C.
On Thu, 2017-05-04 at 14:13 +0200, Cédric Le Goater wrote: > On 05/04/2017 01:52 PM, Andrew Jeffery wrote: > > On Thu, 2017-05-04 at 12:04 +0930, Joel Stanley wrote: > > > When booting we see something like this: > > > > > > aspeed-smc 1e620000.flash-controller: Using IRQ 17 > > > aspeed-smc 1e620000.flash-controller: DMA support disabled. > > > aspeed-smc 1e620000.flash-controller: mx25l25635e (32768 Kbytes) > > > aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000- 0x22000000 ] 32MB > > > aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000- 0x2a000000 ] 128MB > > > > > > The lack of space after the first hex number haunts me every time I > > > boot a BMC. > > > > > > With this fix we see the pleasingly symmetrical: > > > > > > aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000 - 0x22000000 ] 32MB > > > aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000 - 0x2a000000 ] 128MB > > > > > > > Signed-off-by: Joel Stanley <joel@jms.id.au> > > > > > > --- > > > drivers/mtd/spi-nor/aspeed-smc.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c > > > index 875b029198fc..23622bf62b6b 100644 > > > --- a/drivers/mtd/spi-nor/aspeed-smc.c > > > +++ b/drivers/mtd/spi-nor/aspeed-smc.c > > > @@ -709,7 +709,7 @@ static u32 chip_set_segment(struct aspeed_smc_chip *chip, u32 cs, u32 start, > > > > > > > > size = end - start; > > > > } > > > > > > > > > > > > > > - dev_info(chip->nor.dev, "CE%d window [ 0x%.8x- 0x%.8x ] %dMB", > > > > + dev_info(chip->nor.dev, "CE%d window [ 0x%.8x - 0x%.8x ] %dMB", > > > > > > cs, start, end, size >> 20); > > > > NAK! I want *no* spaces! > > > > Reviewed-by: Andrew Jeffery <andrew@aj.id.au> > > ah ! as you wish, I have no strong feeling on the format :) Sorry, that was a stupid bikeshed joke. I'm happy that someone's done anything with it :) Andrew
diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c index 875b029198fc..23622bf62b6b 100644 --- a/drivers/mtd/spi-nor/aspeed-smc.c +++ b/drivers/mtd/spi-nor/aspeed-smc.c @@ -709,7 +709,7 @@ static u32 chip_set_segment(struct aspeed_smc_chip *chip, u32 cs, u32 start, size = end - start; } - dev_info(chip->nor.dev, "CE%d window [ 0x%.8x- 0x%.8x ] %dMB", + dev_info(chip->nor.dev, "CE%d window [ 0x%.8x - 0x%.8x ] %dMB", cs, start, end, size >> 20); return size;
When booting we see something like this: aspeed-smc 1e620000.flash-controller: Using IRQ 17 aspeed-smc 1e620000.flash-controller: DMA support disabled. aspeed-smc 1e620000.flash-controller: mx25l25635e (32768 Kbytes) aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000- 0x22000000 ] 32MB aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000- 0x2a000000 ] 128MB The lack of space after the first hex number haunts me every time I boot a BMC. With this fix we see the pleasingly symmetrical: aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000 - 0x22000000 ] 32MB aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000 - 0x2a000000 ] 128MB Signed-off-by: Joel Stanley <joel@jms.id.au> --- drivers/mtd/spi-nor/aspeed-smc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)