Patchwork Add FreeBSD options from specs to freebsd.opt

login
register
mail settings
Submitter Joseph S. Myers
Date Dec. 16, 2010, 11:20 p.m.
Message ID <Pine.LNX.4.64.1012162319030.16840@digraph.polyomino.org.uk>
Download mbox | patch
Permalink /patch/75824/
State New
Headers show

Comments

Joseph S. Myers - Dec. 16, 2010, 11:20 p.m.
In preparation for the driver only accepting options listed in .opt
files, and not other options that simply happen to match some spec,
this patch adds FreeBSD options matched by specs to freebsd.opt.
There are in essence two parts to this patch:

* The -profile and -pthread options from specs in freebsd-spec.h are
  added to freebsd.opt.

* Various linker options listed there as part of eliminating
  WORD_SWITCH_TAKES_ARG also have (in the GNU linker at least) joined
  forms with '=' which would be matched by specs such as %{assert*}
  just like the separate argument forms.  So that they continue to be
  accepted I added the joined forms to freebsd.opt.  (I put rpath=
  here rather than in rpath.opt since some targets using rpath.opt may
  not accept -rpath= in their linkers, and certainly some specs used
  for -rpath for some targets wouldn't handle -rpath= correctly.)

freebsd-spec.h is also used by lots of powerpc*-* targets as part of
supporting -mcall-freebsd.  I didn't do anything about making options
available there (but my inclination is generally not to make target
options available for -mcall-* specs; I don't really feel the -mcall-*
support is useful at present, it just makes powerpc*-* targets
gratuitously different from other targets and so more complicated to
maintain).

Tested building cc1 and xgcc for cross to i686-freebsd8.  OK to
commit?

2010-12-16  Joseph Myers  <joseph@codesourcery.com>

	* config/freebsd.opt (assert=, defsym=, profile, pthread,
	rpath-link=, rpath=, soname=): New Driver options.
Joseph S. Myers - Dec. 24, 2010, 4:54 p.m.
Ping.  This patch 
<http://gcc.gnu.org/ml/gcc-patches/2010-12/msg01340.html> is pending 
review.
Loren James Rittle - Dec. 27, 2010, 10:25 p.m.
OK by me. Regards, Loren

On Thu, Dec 16, 2010 at 5:20 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
>
> 2010-12-16  Joseph Myers  <joseph@codesourcery.com>
>
>        * config/freebsd.opt (assert=, defsym=, profile, pthread,
>        rpath-link=, rpath=, soname=): New Driver options.

Patch

Index: gcc/config/freebsd.opt
===================================================================
--- gcc/config/freebsd.opt	(revision 167956)
+++ gcc/config/freebsd.opt	(working copy)
@@ -26,13 +26,34 @@ 
 assert
 Driver Separate
 
+assert=
+Driver JoinedOrMissing
+
 defsym
 Driver Separate
 
+defsym=
+Driver JoinedOrMissing
+
+profile
+Driver
+
+pthread
+Driver
+
 rpath-link
 Driver Separate
 
+rpath-link=
+Driver JoinedOrMissing
+
+rpath=
+Driver JoinedOrMissing
+
 soname
 Driver Separate
 
+soname=
+Driver JoinedOrMissing
+
 ; This comment is to ensure we retain the blank line above.