diff mbox

[RESEND,v2,03/21] xen-backend: Remove FIXME comment about user_creatable flag

Message ID 20170503203604.31462-4-ehabkost@redhat.com
State New
Headers show

Commit Message

Eduardo Habkost May 3, 2017, 8:35 p.m. UTC 
xen-backend can be plugged/unplugged dynamically when using the
Xen accelerator, so keep the user_creatable flag on the device
class and remove the FIXME comment.

Cc: Juergen Gross <jgross@suse.com>,
Cc: Peter Maydell <peter.maydell@linaro.org>,
Cc: Thomas Huth <thuth@redhat.com>
Cc: sstabellini@kernel.org
Cc: Markus Armbruster <armbru@redhat.com>,
Cc: Marcel Apfelbaum <marcel@redhat.com>,
Cc: Laszlo Ersek <lersek@redhat.com>
Acked-by: Juergen Gross <jgross@suse.com>
Acked-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes series v1 -> v2:
* (New patch added to series)
---
 hw/xen/xen_backend.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Markus Armbruster May 15, 2017, 8:46 a.m. UTC | #1 
Stefano or Anthony, please review.

Eduardo Habkost <ehabkost@redhat.com> writes:

> xen-backend can be plugged/unplugged dynamically when using the
> Xen accelerator, so keep the user_creatable flag on the device
> class and remove the FIXME comment.
>
> Cc: Juergen Gross <jgross@suse.com>,
> Cc: Peter Maydell <peter.maydell@linaro.org>,
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: sstabellini@kernel.org
> Cc: Markus Armbruster <armbru@redhat.com>,
> Cc: Marcel Apfelbaum <marcel@redhat.com>,
> Cc: Laszlo Ersek <lersek@redhat.com>
> Acked-by: Juergen Gross <jgross@suse.com>
> Acked-by: Marcel Apfelbaum <marcel@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes series v1 -> v2:
> * (New patch added to series)
> ---
>  hw/xen/xen_backend.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c
> index 67cb4cb9f0..2b91d2d458 100644
> --- a/hw/xen/xen_backend.c
> +++ b/hw/xen/xen_backend.c
> @@ -619,10 +619,7 @@ static void xendev_class_init(ObjectClass *klass, void *data)
>  
>      dc->props = xendev_properties;
>      set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> -    /*
> -     * FIXME: Set only because we are not sure yet if this device
> -     * will be outside the q35 sysbus whitelist.
> -     */
> +    /* xen-backend devices can be plugged/unplugged dynamically */
>      dc->user_creatable = true;
>  }
diff mbox

Patch

diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c
index 67cb4cb9f0..2b91d2d458 100644
--- a/hw/xen/xen_backend.c
+++ b/hw/xen/xen_backend.c
@@ -619,10 +619,7 @@  static void xendev_class_init(ObjectClass *klass, void *data)
 
     dc->props = xendev_properties;
     set_bit(DEVICE_CATEGORY_MISC, dc->categories);
-    /*
-     * FIXME: Set only because we are not sure yet if this device
-     * will be outside the q35 sysbus whitelist.
-     */
+    /* xen-backend devices can be plugged/unplugged dynamically */
     dc->user_creatable = true;
 }