diff mbox

[2/9] pinctrl: Combine two seq_puts() calls into one call in two functions

Message ID 64ab3ba9-6cfa-fd59-976c-8f22b2b9a2c5@users.sourceforge.net
State New
Headers show

Commit Message

SF Markus Elfring May 2, 2017, 9:22 a.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 1 May 2017 22:42:13 +0200

Some text was put into a sequence by two separate function calls.
Print the same data by a single function call instead.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/pinctrl/pinconf.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

Comments

Andy Shevchenko May 3, 2017, 5:47 p.m. UTC | #1 
On Tue, May 2, 2017 at 12:22 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 1 May 2017 22:42:13 +0200
>
> Some text was put into a sequence by two separate function calls.
> Print the same data by a single function call instead.

I don't see a benefit here, sorry.
This is slow path in any case (printing is slow). Currently code is
neat, you do it slightly harder to parse.
diff mbox

Patch

diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index 1a3fbdf81ecb..a14ae8601b39 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -307,9 +307,9 @@  static int pinconf_pins_show(struct seq_file *s, void *what)
 	struct pinctrl_dev *pctldev = s->private;
 	unsigned i, pin;
 
-	seq_puts(s, "Pin config settings per pin\n");
-	seq_puts(s, "Format: pin (name): configs\n");
-
+	seq_puts(s,
+		 "Pin config settings per pin\n"
+		 "Format: pin (name): configs\n");
 	mutex_lock(&pctldev->mutex);
 
 	/* The pin number can be retrived from the pin controller descriptor */
@@ -352,8 +352,9 @@  static int pinconf_groups_show(struct seq_file *s, void *what)
 	unsigned ngroups = pctlops->get_groups_count(pctldev);
 	unsigned selector = 0;
 
-	seq_puts(s, "Pin config settings per pin group\n");
-	seq_puts(s, "Format: group (name): configs\n");
+	seq_puts(s,
+		 "Pin config settings per pin group\n"
+		 "Format: group (name): configs\n");
 
 	while (selector < ngroups) {
 		const char *gname = pctlops->get_group_name(pctldev, selector);