Patchwork Go patch committed: Don't crash on invalid tuple assignment

login
register
mail settings
Submitter Ian Taylor
Date Dec. 16, 2010, 1:26 a.m.
Message ID <mcrei9izew9.fsf@google.com>
Download mbox | patch
Permalink /patch/75712/
State New
Headers show

Comments

Ian Taylor - Dec. 16, 2010, 1:26 a.m.
This patch to the Go frontend avoids a crash on an invalid tuple
assignment.  Bootstrapped and tested on x86_64-unknown-linux-gnu.
Committed to mainline.

Ian

Patch

diff -r 2d785fe6afc9 go/expressions.cc
--- a/go/expressions.cc	Wed Dec 15 16:42:28 2010 -0800
+++ b/go/expressions.cc	Wed Dec 15 17:15:16 2010 -0800
@@ -8655,6 +8655,9 @@ 
 Type*
 Call_result_expression::do_type()
 {
+  if (this->classification() == EXPRESSION_ERROR)
+    return Type::make_error_type();
+
   // THIS->CALL_ can be replaced with a temporary reference due to
   // Call_expression::do_must_eval_in_order when there is an error.
   Call_expression* ce = this->call_->call_expression();
@@ -8668,34 +8671,25 @@ 
   for (unsigned int i = 0; i < this->index_; ++i)
     {
       if (pr == results->end())
-	return Type::make_error_type();
+	break;
       ++pr;
     }
   if (pr == results->end())
-    return Type::make_error_type();
+    {
+      this->report_error(_("number of results does not match "
+			   "number of values"));
+      return Type::make_error_type();
+    }
   return pr->type();
 }
 
-// Check the type.  This is where we give an error if we're trying to
-// extract too many values from a call.
+// Check the type.  Just make sure that we trigger the warning in
+// do_type.
 
 void
 Call_result_expression::do_check_types(Gogo*)
 {
-  bool ok = true;
-  Call_expression* ce = this->call_->call_expression();
-  if (ce != NULL)
-    ok = this->index_ < ce->result_count();
-  else
-    {
-      // This can happen when the call returns a single value but we
-      // are asking for the second result.
-      if (this->call_->is_error_expression())
-	return;
-      ok = false;
-    }
-  if (!ok)
-    this->report_error(_("number of results does not match number of values"));
+  this->type();
 }
 
 // Determine the type.  We have nothing to do here, but the 0 result
diff -r 2d785fe6afc9 go/statements.cc
--- a/go/statements.cc	Wed Dec 15 16:42:28 2010 -0800
+++ b/go/statements.cc	Wed Dec 15 17:15:16 2010 -0800
@@ -782,6 +782,12 @@ 
     {
       gcc_assert(prhs != this->rhs_->end());
 
+      if ((*plhs)->is_error_expression()
+	  || (*plhs)->type()->is_error_type()
+	  || (*prhs)->is_error_expression()
+	  || (*prhs)->type()->is_error_type())
+	continue;
+
       if ((*plhs)->is_sink_expression())
 	{
 	  b->add_statement(Statement::make_statement(*prhs));
@@ -802,6 +808,12 @@ 
        plhs != this->lhs_->end();
        ++plhs, ++prhs)
     {
+      if ((*plhs)->is_error_expression()
+	  || (*plhs)->type()->is_error_type()
+	  || (*prhs)->is_error_expression()
+	  || (*prhs)->type()->is_error_type())
+	continue;
+
       if ((*plhs)->is_sink_expression())
 	continue;