| Message ID | 1493621998-4982-1-git-send-email-gottfried.haider@gmail.com |
|---|---|
| State | Deferred |
| Headers | show |
Does anyone have time to review this patch? I wrote this with the Raspberry Pi in mind, but they want to see this at least acknowledged by upstream before carrying in their downstream tree (which seems quite sensible to me). Thanks in advance, Gottfried -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c index a813239..83f2b0b 100644 --- a/drivers/pwm/sysfs.c +++ b/drivers/pwm/sysfs.c @@ -263,6 +263,7 @@ static int pwm_export_child(struct device *parent, struct pwm_device *pwm) export->pwm = pwm; mutex_init(&export->lock); + export->child.class = parent->class; export->child.release = pwm_export_release; export->child.parent = parent; export->child.devt = MKDEV(0, 0);
Notifications for devices without bus or class set get dropped by dev_uevent_filter. Adding the class to the exported child matches what the gpio subsystem is doing. With this change exporting a channel triggers a udev event, which gives userspace a chance to fixup permissions and makes it possible for non-root users to make use of the pwm subsystem. Signed-off-by: Gottfried Haider <gottfried.haider@gmail.com> --- drivers/pwm/sysfs.c | 1 + 1 file changed, 1 insertion(+)