Message ID | 1493543684-7038-1-git-send-email-Yuval.Mintz@cavium.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wG23G4Wwxz9s7C for <patchwork-incoming@ozlabs.org>; Sun, 30 Apr 2017 19:15:54 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="XXwPlXPi"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1427268AbdD3JOy (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Sun, 30 Apr 2017 05:14:54 -0400 Received: from mail-cys01nam02on0048.outbound.protection.outlook.com ([104.47.37.48]:42256 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1163843AbdD3JOx (ORCPT <rfc822;netdev@vger.kernel.org>); Sun, 30 Apr 2017 05:14:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OHGZR9r0/sVWEYX5vyGLG/hX7tYUQbdxoTQYTqYKGxA=; b=XXwPlXPiIK5/vZBw3U0ly0XYN2p/xK/Gi1M6T09fqLDvCMPyMgkhEkDcogBAgr88yTd6TxO42KHLHi+DUcAYS2YFKJ99maKjXpnwet/6nQU8+YTrw+2GdPpYM+UskWZxrzNBEln4xflveWumFpdeR0DYvpZCpBm7wY2AAP5Zdmg= Received: from MWHPR07CA0010.namprd07.prod.outlook.com (10.172.94.20) by SN2PR07MB2528.namprd07.prod.outlook.com (10.167.15.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1061.12; Sun, 30 Apr 2017 09:14:51 +0000 Received: from BY2FFO11FD009.protection.gbl (2a01:111:f400:7c0c::135) by MWHPR07CA0010.outlook.office365.com (2603:10b6:300:dc::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1061.12 via Frontend Transport; Sun, 30 Apr 2017 09:14:50 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; davemloft.net; dkim=none (message not signed) header.d=none; davemloft.net; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BY2FFO11FD009.mail.protection.outlook.com (10.1.14.73) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1047.9 via Frontend Transport; Sun, 30 Apr 2017 09:14:50 +0000 Received: from localhost.qlogic.org (10.185.6.94) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Sun, 30 Apr 2017 02:14:48 -0700 From: Yuval Mintz <Yuval.Mintz@cavium.com> To: <netdev@vger.kernel.org>, <davem@davemloft.net> CC: <Sudarsana.Kalluru@cavium.com>, Yuval Mintz <Yuval.Mintz@cavium.com> Subject: [PATCH net-next] qed: Prevent warning without CONFIG_RFS_ACCEL Date: Sun, 30 Apr 2017 12:14:44 +0300 Message-ID: <1493543684-7038-1-git-send-email-Yuval.Mintz@cavium.com> X-Mailer: git-send-email 1.9.3 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39400400002)(39850400002)(39840400002)(2980300002)(428002)(189002)(199003)(9170700003)(101416001)(36756003)(4326008)(6666003)(104016004)(50986999)(48376002)(305945005)(77096006)(50466002)(47776003)(50226002)(53416004)(76506005)(2906002)(8936002)(107886003)(38730400002)(81166006)(5660300001)(189998001)(8676002)(5003940100001)(478600001)(106466001)(105586002)(86362001)(356003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2528; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD009; 1:OKR2LX7gVmxEWKbXdjDPePygV5mNkOfdSmSkrtRYEg8oEcUSJw1D7o+Dg57cvgJJqiN+i1P6u6oAlBAYEBMWVbDC2/do7d5LSAgR66v6NyNF19XNwRB3XeI0NPDlRbo5KdDSSwgA4rh3HlvXhNVpyjnTXht//m4Tbp0U7tQbjM1N4esWMgQm7q/NTprr0VeCasOrqk0otYKsYNOW/ZSqAvZbVTr7twhnQTozNgF4prf6bST+vVZlCeF9ej8cWUmt2avckkmbde7XvNFLc+lGkBdZM9yVLJaQuaoCt1LLlgnZG6VrnR3lxjCTllgiZkShlXfHlMhaPWBzH1C9ASiNT3wSXxsVfvfzqYqJAJhFLOwMjbVofugkHr0esXM54oXJ3OVIV5VALHnAHrPy2Our85LsKRTbgZqIzF4LdZOVLzAl8PJwmlYduW8kf3nVkhEtRLL2reLAF499JCQ4Co1Cp1Tej2C5SloDsecuEWpYQEFQDT060YD4aj2uBlxOeBOj1UK7n/voBiXoQyRgbr8qfAhorCmDwaS3nI+8YGcYhKcmFRiajnE8KSynikODbLZ1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3e410a84-c8db-4a4c-f25c-08d48fa95b01 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:SN2PR07MB2528; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 3:Bzla26iwT+V1NHsTxELTQ+r4j60urpRiAdYlqP9qz5Ap6PPrKTdQJ1QCLzoBjAjs/r6juW3qMpf0ExF0f0WHYNk1M7Rw1kZJFF7+VFYW46FkexEB3iFJU66bsRvrOedeNND4ZevKl7GtsDe11K8ezP0kBepgCDK0aYo15Jq61EVEPvTnpi8OD1cZuLzfXT5GHPQXVA239t9CKMog2uWn0vsSI7+cxUZxpbWiVNo8SngyDen3HOa38cCmSlpIWDZ6LVQMl2uEoFX90gK4g6D5MSDqkMkxcE/R4/TG1hTdTlNVNtbQGDDJ4Ypz4UCm082ydL8vDOZbk0VkrhGToAzFJQJdTWWpfS9pmxPoSnx5zHAbsqK9GHZCfs+jNZc3laLQHIH/qAU3/bt9jlBPJrJ5YBp+yjJuIZn8hO7FoRZJnKLWL7ekLkTEt2aXZI+pngu67EbBwLk6toIu6fsO8hcipFSHnm8b+iFByktckkXoaDO9AWdGHu4UsJ1VBi7JJhwH X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 25:wNq/DhyJEcjm5ThimC9ulaRu11gzZznsLd3PoMbp3xWfkbdDBVeeKMZ23cSDQ8EAxDr7tTAiAdfkHiTTlU2xMwDatLRekE+iGeeIV7pKC9YTAo0hO010o6t8kLpOyhA+wbnwLplbPAjgQLFdVW2cJNb5qVTlaPZQpAtcB/+wegaW0rVeOuOD1Oh4FTHsBHsLIvOPji3sdGhW0djO6qHdlt9mK5moGGrQmlZsqnYQICQaI7SyLfvE0T6fYj1Apw3qpdStAlVBnG0CosEIOhjVb/TGdLTOUYQCpxSpPtfl2Djt+hVym+7YbYhXozbSQQxc/N2uapwzjQTSo9XZz9qDea/bnBbybs2KXrd1fT6m4ujuk6BsRAJsbARrXC6ACmacSbEbVyQLAWJRQXg6VHgI7Syw4ya0Ixvs99viCiqppTP31cNTksIOnTv+Zof47oa0; 31:UqCSpwChIvl63bKP0DWN2nJ4JAPUhymSGZ3tS7SXH9opb8H+Fy8cCcWtNGGoK+4mHVIMUTswH3SMZmfcNR0NVoUBgvkPSZuFXTmKFiv0vErO4Z7mSTqjr9MIKziWoJIhmPoIZ/ADvy2WJIu0Xs2B7c84A9NXFp0XlSlwKnnFQpr3eQ/UGX+J3oZfjgU7iKKcaaJmYTG8EJzpSMIPwzFBpJEs3DTsEo7Ty5PXlBTqwDKoB/mbJQLF27ofzsX/IFr8FIiS+R9CnhRpYLCFbtJkErMyxELgnpSW5lOLO0g5bAg= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 20:RRH9rJOkm1E9g2++J05FgF8NQdYD/Gt9+mj3rfeglY1KvxVGLduBexSgadO/WpljgFNplS5QH5ZIbtBN/r6MzgHzWNcpjrK7lqqXRFlPgKhrEnBCH6n3g4/HwdUNfb2+XT6gXSq8obTP6FLOqkPfEyNo82C7A/0zWL4eJqUUH4AqjxO1Hlj9asjqw0I8dkXse+WI7J2tWSPsv3E0ELehjpYBO0I3Kp0gCQ648eov9PXK8Bap9J1voR1clqP/h47NsV32wngysw+BHiJRujWs1JB7dKwGJRNZK0NNE+gDQiQUxAmikeEA6/RA4zHFUzwoFnwL2gKhs+T5ntFQUIFGkSnP96TVfGjCJdDEf4QjGhxO7iqoOgicOmTyhdhtHP5HcQyGfjTBPnju3FD+zXBJxd/VCGnMWIp9TfmleraxDLjwzBDtxmFhYm4dbj2CyIsF8EwiXgzdu2GDlnlIkIVW9BeliOs6ROw/0pgblUAr2u9Bn7l+WEh0/XPeAqgrzBge X-Microsoft-Antispam-PRVS: <SN2PR07MB252881BA0F0CB603FAE62CAA8D150@SN2PR07MB2528.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(13024025)(13018025)(13023025)(13017025)(8121501046)(5005006)(13015025)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(6072148); SRVR:SN2PR07MB2528; BCL:0; PCL:0; RULEID:; SRVR:SN2PR07MB2528; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 4:twQ5yfnoPhhwPLpejZrhssaz7T9AImTrSV7vQwI6uvHrUjqKNB8Q05Q5adDsI8xFxVtSVRbzh7NrMfzWcsTPOjBeFWu9Hm5k09fmIT55mNIGOpzF+xYyY4pQ0fNUZKsx25PwABBkqhNcuIE7aak5MOSMCxBCemFqP1bCPVmghAPAjd4pm3ukVAPmixpM2H8tLvnge6rUIz9s3FAshEkiLY2R5NOoJJYvVmoyaRhE1/KIte9BUPbNi9BH323g8O5H3yfpZSEO4X4ArnQl4f+YOM4iO+QR/ipzPRuc6EZtXLURxqSOrqhkgu1cHhkwM5VRirPwjlUEr1ZM2HRe0KN+FStegK+2cEwcV5oPBeHnQsmPInzWrP1r/KVjeCly7A6rWg7Ck6tML8afdm94PKIWaOhqCqg52m2I+fl09+KrtjMdWNjm8Uz6hqCiMUSdKHJKR6kkxuF0h4i2zCbyc788oS0V2ALoFt8hosF5IOwxf06zcd82uGwjoj4Jc0QvgiaCYSNLgzAlHoDtHO8W5DBxxRPu2YxGXp4CKusINozkXLQ1rlTKPCZ5rdPgqv5AemudX0BbdUz7UN6/fSElty5fqKCzYsbdTszkhutxSN8NUIzSzzwlXPPen+s3VWqXwPfs3CupJu9iMqZ9f1r64CDCEQtK84hQaMeXIsXMW90GEnBHGCMghuqM420zuElbDSLAMxGAFml0yr4PbIiDoRGs+5fBaAndwIQg45CzDIkGHXDTv0QZdCW37MvOtVkN3KKFhzKlZbQlCWORbgKzkTwWRikuwkXPFwOGH/VDtbVHckL2wuOlDlIXbb8mOOR2ihLE5yJwXot+Or5aji9yI0Kj0FyM5LY6SlD9gRqWOF6fHPP/8CoB9qG1A0CBtfe+fR6m X-Forefront-PRVS: 0293D40691 X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 23:dPeLIUp44yN4oR1z0v9Biw/gQR2if/8+Hc56fPoGkyGBjhmNt6jLq6pksITcZ+wdJzYEMrk9/lb1CQAzPgL8LB02BppZP7ZbfEXotzFhUS15bpk27Y1Sa5AGbg1OfI2KwJ1Z4SrWiCDzPDCSYo2Z27DlIy8mxoZcyR3ULECpg3yPZllvVfnLGzshnVAla1UZnl6FZJ5w7br/kRalG1xTfmAndKJjjI9K681ctL8t1r5/4YGdO8iR4dTthp95NFU3uj+J+L40FKgqFJpqtZRv8yOD+NYZY8v4yC4cHH0JCBUQZ5lxKRcVHia2+Rkil//ZEFsb4/VpqHH86iAPshBTySwVfKUU5FLseX6AoSfQgBLriAQWwdMz5tH5LqfU/TGgPcfAoQWbcWot85KVMkDAMXMcr0zu8YhaOpRa63ScYWGEX0bQPODpOSCUBB3RD0pm3DE44tOPb6Gl8kHnZNQJnP6MhXAfFgebwpgYFZs1P8fNC1Sef/B07V+eq+a6MqUfo8kp03fVPeOXdn6vYnum8s2I3MoGectY4lEGXYWrT8JvmmhEKOVtqHZOLNeAXjxsdYAQc5O9yyBcw3lZh3rmNLz7cgJI+XgXCy9UagTng6mLgdVs7vrmypXlaOR08kmH+cZkwpMbVk0sRO4uBWsT1wYvhBGpXxfm14MrjIF+MngR2GJLQCklsDKcdgnkPZm8DszMsVl41B2dtVM2WioUtQGY+v+q7uQFLFV3pgWxtasug1i4cLgm6/FN+Geqpbu7ULrE+jCnRu+QEtdZODTptH8COFStfOdFBG6kxai2Eykq9/a+mg+TNT0H0Cq4XDxdNRAAGg//5bezRzrjmuHiGI9ttjobJSD1n5lewHfmKWaxaAzdow0hgjwnCqQJ6EHD6KiJxC888VfAQrHJEYEvcP6NnAWG83kP7za+lieLinifwAr9sMelo0dQjsT+RX5H X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 6:T5ZlTZ+sq32v+8M6daLjzAAsr7aROsQitPVJyc5Ks9Q7y+TEhx6OG3W6H8KEjgoqnaQn7/+EV7wnZKfFW631NZ+fZlsC/a90t5efLqJl1AjekUhCLuJyq7cXKOwszEKaTx4XN3YOcQpf3+U2IosncdjKDGdShoaVYT02chFMNaR2xshfIyvCIkPAj73JRW9vaYB13XrS5cqLirG7pKgNiKwcxYCgLArCI9RJFHEwBHqdf1aPogIR9epSAw5ECoMcqcadDx3EsQ8K8NpZwjZ6d8Yoa5JtGcVFBFGkPuEtLRHlm1g7Stc9eoIbLkWhnI10ZSu2Iv9kWhQiG69BRmo4/GxGfuRUdSzb9VM94oz6aoBqnsVBpAGbAV9U0VkXoYu+6bQCc2ODc9tRDBG9FGAf9rLkbShxSzu0rUR/tqP/NDT5Mg2rR95lf7tre6bbBnFs+/gg9CG65rJU042AOwmS1IiaFgZa9mwQMtguL0Ej60din6gw1yf1y4VMgoV6ABKaxD+hSCHGHRIaO921AymIDA==; 5:kHjQwpO/IyAzYiScCGYGWgDfVJCnKmRa1gLgdXJlvARN9dh2eUrTDImc5gQCfh4yxAsawExi3GYJhizWokFOai72S/TIKpUFFTRRPs98gXtpUsz95PlOcvj1Kky1hbfBg4ekS6I1yayPUiNJFLsmrA==; 24:wz785JuMCRyYDcM558/MJu8D8CnGSjiaP5/wAhSiXZjTO5+0xzMbZZ9ApZkcMq6bZzA6rbZ0bD8UUjtmUSQ3C+hAqlyxobc/gCIoxb4ZiP4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2528; 7:r2ZJAVZxHoAsPeBLQR6ZhMP4uey8bX5Y5S0U5H9KswBVBQlb1d0cfetVl5iC4aO4OOVvf6Sp9aRBvAeGfhcOuXCMHca6DbiN/d1e6l1owZw2P+J6uGv16RnXdmGXP8tHnNqKhT5Tv1nv/YJGFZbIF5raRjety86LcW/lD/HmvkB52MAlt+PMCK59NhxnUWtWh41svvlTm1nY4tTqQrgRQGFYGqbKkLtPfplF+4HGASJNc5H+QUd6DHGJherW4faRZD6vo8vVlcG/TFr6FRhc+N6yLMLO1dzTeD+Fd1FYozXEqY3nE2x92Rw7wtATZYCDtQX/CGk44kwp/P/+XMWURw== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2017 09:14:50.2997 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2528 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
From: Yuval Mintz <Yuval.Mintz@cavium.com> Date: Sun, 30 Apr 2017 12:14:44 +0300 > After removing the PTP related initialization from slowpath start, > the remaining PTT entry is required only in case CONFIG_RFS_ACCEL is set. > Otherwise, it leads to a warning due to it being unused. > > Fixes: d179bd1699fc ("qed: Acquire/release ptt_ptp lock when enabling/disabling PTP") > Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com> Also applied, thanks.
diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c index 8a5a064..59992cf 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -928,7 +928,9 @@ static int qed_slowpath_start(struct qed_dev *cdev, struct qed_tunnel_info tunn_info; const u8 *data = NULL; struct qed_hwfn *hwfn; +#ifdef CONFIG_RFS_ACCEL struct qed_ptt *p_ptt; +#endif int rc = -EINVAL; if (qed_iov_wq_start(cdev))
After removing the PTP related initialization from slowpath start, the remaining PTT entry is required only in case CONFIG_RFS_ACCEL is set. Otherwise, it leads to a warning due to it being unused. Fixes: d179bd1699fc ("qed: Acquire/release ptt_ptp lock when enabling/disabling PTP") Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com> --- Hi Dave, Please consider applying this to `net-next'. Thanks, Yuval --- drivers/net/ethernet/qlogic/qed/qed_main.c | 2 ++ 1 file changed, 2 insertions(+)