Patchwork Fix migrate set speed doc arg

login
register
mail settings
Submitter Luiz Capitulino
Date Dec. 15, 2010, 7:56 p.m.
Message ID <20101215175618.530eec6c@doriath>
Download mbox | patch
Permalink /patch/75676/
State New
Headers show

Comments

Luiz Capitulino - Dec. 15, 2010, 7:56 p.m.
We used to ignore any fractional part in 0.13, but due to recent
changes (started with 9f9b17a4f0865286391e4d3a0a735230122a2289)
migrate_set_speed will reject the fractional part.

We don't expect existing clients to be relying on this, but we
need to update the documentation to reflect the change.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 qmp-commands.hx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Markus Armbruster - Dec. 15, 2010, 9:22 p.m.
Luiz Capitulino <lcapitulino@redhat.com> writes:

> We used to ignore any fractional part in 0.13, but due to recent
> changes (started with 9f9b17a4f0865286391e4d3a0a735230122a2289)
> migrate_set_speed will reject the fractional part.
>
> We don't expect existing clients to be relying on this, but we
> need to update the documentation to reflect the change.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

Documentation broken by commit ed3d4a80.

ACK
Aurelien Jarno - Dec. 27, 2010, 8:44 p.m.
On Wed, Dec 15, 2010 at 05:56:18PM -0200, Luiz Capitulino wrote:
> We used to ignore any fractional part in 0.13, but due to recent
> changes (started with 9f9b17a4f0865286391e4d3a0a735230122a2289)
> migrate_set_speed will reject the fractional part.
> 
> We don't expect existing clients to be relying on this, but we
> need to update the documentation to reflect the change.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  qmp-commands.hx |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, applied.

> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 3486223..164ecbc 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -510,7 +510,7 @@ Set maximum speed for migrations.
>  
>  Arguments:
>  
> -- "value": maximum speed, in bytes per second (json-number)
> +- "value": maximum speed, in bytes per second (json-int)
>  
>  Example:
>  
> -- 
> 1.7.3.3.585.g74f6e
> 
> 
>

Patch

diff --git a/qmp-commands.hx b/qmp-commands.hx
index 3486223..164ecbc 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -510,7 +510,7 @@  Set maximum speed for migrations.
 
 Arguments:
 
-- "value": maximum speed, in bytes per second (json-number)
+- "value": maximum speed, in bytes per second (json-int)
 
 Example: