diff mbox

Fix signal.h bsd_signal namespace (bug 21445)

Message ID alpine.DEB.2.20.1704281713070.7148@digraph.polyomino.org.uk
State New
Headers show

Commit Message

Joseph Myers April 28, 2017, 5:13 p.m. UTC 
signal.h declares bsd_signal for __USE_XOPEN.  But this function was
obsoleted in the 2001 edition of POSIX and removed in the 2008
edition, so it should not be declared when the 2008 edition is in use.
This patch fixes the conditionals accordingly.  (This does not fix any
conform/ test failures because of other namespace issues in signal.h.)

Tested for x86_64.

2017-04-28  Joseph Myers  <joseph@codesourcery.com>

	[BZ #21445]
	* signal/signal.h [__USE_XOPEN2K8] (bsd_signal): Do not declare.

Comments

Joseph Myers May 4, 2017, 1:47 p.m. UTC | #1 
Ping.  This patch 
<https://sourceware.org/ml/libc-alpha/2017-04/msg00576.html> is pending 
review.
Adhemerval Zanella Netto May 4, 2017, 5:31 p.m. UTC | #2 
On 04/05/2017 10:47, Joseph Myers wrote:
> Ping.  This patch 
> <https://sourceware.org/ml/libc-alpha/2017-04/msg00576.html> is pending 
> review.
> 

LGTM, thanks.
diff mbox

Patch

diff --git a/signal/signal.h b/signal/signal.h
index 84f2a1f..6db2d2f 100644
--- a/signal/signal.h
+++ b/signal/signal.h
@@ -108,7 +108,7 @@  extern __sighandler_t __REDIRECT_NTH (signal,
 # endif
 #endif
 
-#ifdef __USE_XOPEN
+#if defined __USE_XOPEN && !defined __USE_XOPEN2K8
 /* The X/Open definition of `signal' conflicts with the BSD version.
    So they defined another function `bsd_signal'.  */
 extern __sighandler_t bsd_signal (int __sig, __sighandler_t __handler)