| Message ID | 20170428054227.9176-1-rashmica.g@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 04/28/2017 11:12 AM, Rashmica Gupta wrote: > Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com> Please describe a bit about the function/feature you are trying to add with this new config option. The subject says " Add config option for removal of memory" but I guess its not related to memory hotplug but about hardware enabled tracing IIUC. Hence it should have some amount of description. > --- > arch/powerpc/platforms/powernv/Kconfig | 4 ++++ > arch/powerpc/platforms/powernv/Makefile | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/arch/powerpc/platforms/powernv/Kconfig b/arch/powerpc/platforms/powernv/Kconfig > index 6a6f4ef..1b8b3a8 100644 > --- a/arch/powerpc/platforms/powernv/Kconfig > +++ b/arch/powerpc/platforms/powernv/Kconfig > @@ -30,3 +30,7 @@ config OPAL_PRD > help > This enables the opal-prd driver, a facility to run processor > recovery diagnostics on OpenPower machines > + > +config HARDWARE_TRACING This is too generic for platform specific feature and also it does not intend to fit into a generic HW tracing infrastructure. IMHO it should be named something like "PPC64_HARDWARE_TRACING" or something similar. > + bool 'Enable removal of memory for hardware memory tracing' If this memory is going to be taken out of memblock like normal memory hotplug and eventually goes away from kernel control, then you need to be more specific about its usage.
On 28/04/17 19:39, Anshuman Khandual wrote: > On 04/28/2017 11:12 AM, Rashmica Gupta wrote: >> Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com> > Please describe a bit about the function/feature you are trying > to add with this new config option. The subject says " Add config > option for removal of memory" but I guess its not related to > memory hotplug but about hardware enabled tracing IIUC. Correct! > Hence > it should have some amount of description. > >> --- >> arch/powerpc/platforms/powernv/Kconfig | 4 ++++ >> arch/powerpc/platforms/powernv/Makefile | 1 + >> 2 files changed, 5 insertions(+) >> >> diff --git a/arch/powerpc/platforms/powernv/Kconfig b/arch/powerpc/platforms/powernv/Kconfig >> index 6a6f4ef..1b8b3a8 100644 >> --- a/arch/powerpc/platforms/powernv/Kconfig >> +++ b/arch/powerpc/platforms/powernv/Kconfig >> @@ -30,3 +30,7 @@ config OPAL_PRD >> help >> This enables the opal-prd driver, a facility to run processor >> recovery diagnostics on OpenPower machines >> + >> +config HARDWARE_TRACING > This is too generic for platform specific feature and also it does > not intend to fit into a generic HW tracing infrastructure. IMHO > it should be named something like "PPC64_HARDWARE_TRACING" or > something similar. > >> + bool 'Enable removal of memory for hardware memory tracing' > If this memory is going to be taken out of memblock like normal > memory hotplug and eventually goes away from kernel control, then > you need to be more specific about its usage. > All good points! Thanks for the review.
diff --git a/arch/powerpc/platforms/powernv/Kconfig b/arch/powerpc/platforms/powernv/Kconfig index 6a6f4ef..1b8b3a8 100644 --- a/arch/powerpc/platforms/powernv/Kconfig +++ b/arch/powerpc/platforms/powernv/Kconfig @@ -30,3 +30,7 @@ config OPAL_PRD help This enables the opal-prd driver, a facility to run processor recovery diagnostics on OpenPower machines + +config HARDWARE_TRACING + bool 'Enable removal of memory for hardware memory tracing' + depends on PPC_POWERNV && MEMORY_HOTPLUG diff --git a/arch/powerpc/platforms/powernv/Makefile b/arch/powerpc/platforms/powernv/Makefile index b5d98cb..e61be1b 100644 --- a/arch/powerpc/platforms/powernv/Makefile +++ b/arch/powerpc/platforms/powernv/Makefile @@ -12,3 +12,4 @@ obj-$(CONFIG_PPC_SCOM) += opal-xscom.o obj-$(CONFIG_MEMORY_FAILURE) += opal-memory-errors.o obj-$(CONFIG_TRACEPOINTS) += opal-tracepoints.o obj-$(CONFIG_OPAL_PRD) += opal-prd.o +obj-$(CONFIG_HARDWARE_TRACING) += memtrace.o
Signed-off-by: Rashmica Gupta <rashmica.g@gmail.com> --- arch/powerpc/platforms/powernv/Kconfig | 4 ++++ arch/powerpc/platforms/powernv/Makefile | 1 + 2 files changed, 5 insertions(+)