| Message ID | 524b7fc8-1eca-a7d8-7bc7-6743be17c208@codeaurora.org |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
On Fri, 28 Apr 2017 11:13:33 +0530 Sricharan R <sricharan@codeaurora.org> wrote: > Hi Ralph, > > On 4/27/2017 8:10 PM, Ralph Sennhauser wrote: > > On Thu, 27 Apr 2017 19:05:09 +0530 > > Sricharan R <sricharan@codeaurora.org> wrote: > > > >> Hi, > >> > >> On 4/26/2017 9:45 PM, Ralph Sennhauser wrote: > >>> Hi Sricharan R, > >>> > >>> Commit 09515ef5ddad ("of/acpi: Configure dma operations at probe > >>> time for platform/amba/pci bus devices") causes a kernel panic as > >>> in the log below on an armada-385. Reverting the commit fixes the > >>> issue. > >>> > >>> Regards > >>> Ralph > >> > >> Somehow not getting a obvious clue on whats going wrong with the > >> logs below. From the log and looking in to dts, the drivers seems > >> to the one for "marvell,armada-370-neta". > > > > Correct. > > > >> Issue looks the data from the dma > >> has gone bad and subsequently referring the wrong data has resulted > >> in the crash. Looks like the dma_masks is the one going wrong. > >> Can i get some logs from mvneta_probe, about dev->dma_mask, > >> dev->coherent_dma_mask and dev->dma_ops with and without the patch > >> to see whats the difference ? > > > > Not sure I understood what exactly you are after. Might be faster to > > just send me a patch with all debug print statements you like to > > see. > > Attached the patch with debug prints. > > Regards, > Sricharan > Hi Sricharan With commit 09515ef5ddad [ 1.288962] mvneta f1070000.ethernet: dev->dma_mask 0xffffffff [ 1.294827] mvneta f1070000.ethernet: dev->coherent_dma_mask 0xffffffff [ 1.301472] mvneta f1070000.ethernet: dev->dma_ops 0x40b00c0601460 [ 1.322047] mvneta f1034000.ethernet: dev->dma_mask 0xffffffff [ 1.327904] mvneta f1034000.ethernet: dev->coherent_dma_mask 0xffffffff [ 1.334549] mvneta f1034000.ethernet: dev->dma_ops 0x40b00c0601460 With the patch reverted, the build that works [ 1.289001] mvneta f1070000.ethernet: dev->dma_mask 0xffffffff [ 1.294866] mvneta f1070000.ethernet: dev->coherent_dma_mask 0xffffffff [ 1.301511] mvneta f1070000.ethernet: dev->dma_ops 0x40b00c06014a8 [ 1.317005] mvneta f1034000.ethernet: dev->dma_mask 0xffffffff [ 1.322867] mvneta f1034000.ethernet: dev->coherent_dma_mask 0xffffffff [ 1.329508] mvneta f1034000.ethernet: dev->dma_ops 0x40b00c06014a8 Regards Ralph
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index d297011..250f0b2 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -4146,6 +4146,12 @@ static int mvneta_probe(struct platform_device *pdev) int phy_mode; int err; int cpu; + struct device *ddev = &pdev->dev; + + + dev_err(ddev, "dev->dma_mask 0x%llx\n", *(ddev->dma_mask)); + dev_err(ddev, "dev->coherent_dma_mask 0x%llx\n", ddev->coherent_dma_mask); + dev_err(ddev, "dev->dma_ops 0x%llx\n", ddev->dma_ops); dev = alloc_etherdev_mqs(sizeof(struct mvneta_port), txq_number, rxq_number); if (!dev)