diff mbox

sctp: fix the return value of getting the sctp partial delivery point

Message ID 4D0823A1.6080307@cn.fujitsu.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Wei Yongjun Dec. 15, 2010, 2:10 a.m. UTC
Get the sctp partial delivery point using SCTP_PARTIAL_DELIVERY_POINT
socket option should return 0 if success, not -ENOTSUPP.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
 net/sctp/socket.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Vlad Yasevich Dec. 15, 2010, 3:53 p.m. UTC | #1
On 12/14/2010 09:10 PM, Wei Yongjun wrote:
> Get the sctp partial delivery point using SCTP_PARTIAL_DELIVERY_POINT
> socket option should return 0 if success, not -ENOTSUPP.
> 

Ack.

-vlad

> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
> ---
>  net/sctp/socket.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index 1bc5203..8628e8e 100644
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -5050,7 +5050,7 @@ static int sctp_getsockopt_partial_delivery_point(struct sock *sk, int len,
>  	if (copy_to_user(optval, &val, len))
>  		return -EFAULT;
>  
> -	return -ENOTSUPP;
> +	return 0;
>  }
>  
>  /*

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Dec. 16, 2010, 10:49 p.m. UTC | #2
From: Vladislav Yasevich <vladislav.yasevich@hp.com>
Date: Wed, 15 Dec 2010 10:53:14 -0500

> On 12/14/2010 09:10 PM, Wei Yongjun wrote:
>> Get the sctp partial delivery point using SCTP_PARTIAL_DELIVERY_POINT
>> socket option should return 0 if success, not -ENOTSUPP.
>> 
> 
> Ack.
> 
> -vlad
> 
>> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>

Applied, thanks everyone.

Vlad, please use properly formed full "Acked-by: ..." in the
future otherwise automated tools don't pick it up and it's
therefore more likely your ACK gets lost.

Thanks :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 1bc5203..8628e8e 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -5050,7 +5050,7 @@  static int sctp_getsockopt_partial_delivery_point(struct sock *sk, int len,
 	if (copy_to_user(optval, &val, len))
 		return -EFAULT;
 
-	return -ENOTSUPP;
+	return 0;
 }
 
 /*