| Message ID | 20170427101403.25134-2-lokeshvutla@ti.com |
|---|---|
| State | Accepted |
| Commit | 690485e01b303ed716681c0dee840c2a78448530 |
| Delegated to: | Tom Rini |
| Headers | show |
On Thu, Apr 27, 2017 at 03:43:58PM +0530, Lokesh Vutla wrote: > Instead of defining command options in every defconfig, > define a common Kconfig symbol that consolidates all command > options that are supported by any TI platform. Also use imply > keyword so that that specific option can be disabled if > not required. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> Reviewed-by: Tom Rini <trini@konsulko.com>
On Thu, Apr 27, 2017 at 7:43 AM, Tom Rini <trini@konsulko.com> wrote: > On Thu, Apr 27, 2017 at 03:43:58PM +0530, Lokesh Vutla wrote: > >> Instead of defining command options in every defconfig, >> define a common Kconfig symbol that consolidates all command >> options that are supported by any TI platform. Also use imply >> keyword so that that specific option can be disabled if >> not required. >> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > > Reviewed-by: Tom Rini <trini@konsulko.com> > I wonder if it would make sense to make these more generic and put them under the OMAP34XX, OMAP4, ... headings. This way we wouldn't have a bunch of copies for everyone's boards. I haven't tried it, but I assume that if ou disable the features in the menuconfig and savedefconfig to update the config files it would leave the de-selected items. I realize that the upfront work might be a little more, but I think it would really clean stuff up. It's not a request, but just a brainstorming idea. adam > -- > Tom > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot >
On Thu, Apr 27, 2017 at 08:21:52AM -0500, Adam Ford wrote: > On Thu, Apr 27, 2017 at 7:43 AM, Tom Rini <trini@konsulko.com> wrote: > > On Thu, Apr 27, 2017 at 03:43:58PM +0530, Lokesh Vutla wrote: > > > >> Instead of defining command options in every defconfig, > >> define a common Kconfig symbol that consolidates all command > >> options that are supported by any TI platform. Also use imply > >> keyword so that that specific option can be disabled if > >> not required. > >> > >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > > > > Reviewed-by: Tom Rini <trini@konsulko.com> > > I wonder if it would make sense to make these more generic and put > them under the OMAP34XX, OMAP4, ... headings. This way we wouldn't > have a bunch of copies for everyone's boards. I haven't tried it, but > I assume that if ou disable the features in the menuconfig and > savedefconfig to update the config files it would leave the > de-selected items. I realize that the upfront work might be a little > more, but I think it would really clean stuff up. It's not a request, > but just a brainstorming idea. So, this is something that I've asked TI to make. The issue here is that for all official TI EVMs there is a desire to have a consistent set of commands available to the users. I think that long term, we do need to make more things globally be default y as well. But I see this more as being akin to DISTRO_DEFAULTS, in that it's a collection of default that a group sees as being important.
On Thu, Apr 27, 2017 at 8:39 AM, Tom Rini <trini@konsulko.com> wrote: > On Thu, Apr 27, 2017 at 08:21:52AM -0500, Adam Ford wrote: >> On Thu, Apr 27, 2017 at 7:43 AM, Tom Rini <trini@konsulko.com> wrote: >> > On Thu, Apr 27, 2017 at 03:43:58PM +0530, Lokesh Vutla wrote: >> > >> >> Instead of defining command options in every defconfig, >> >> define a common Kconfig symbol that consolidates all command >> >> options that are supported by any TI platform. Also use imply >> >> keyword so that that specific option can be disabled if >> >> not required. >> >> >> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> >> > >> > Reviewed-by: Tom Rini <trini@konsulko.com> >> >> I wonder if it would make sense to make these more generic and put >> them under the OMAP34XX, OMAP4, ... headings. This way we wouldn't >> have a bunch of copies for everyone's boards. I haven't tried it, but >> I assume that if ou disable the features in the menuconfig and >> savedefconfig to update the config files it would leave the >> de-selected items. I realize that the upfront work might be a little >> more, but I think it would really clean stuff up. It's not a request, >> but just a brainstorming idea. > > So, this is something that I've asked TI to make. The issue here is > that for all official TI EVMs there is a desire to have a consistent set > of commands available to the users. I think that long term, we do need > to make more things globally be default y as well. But I see this more > as being akin to DISTRO_DEFAULTS, in that it's a collection of default > that a group sees as being important. > That makes sense. thanks adam > -- > Tom
On Thu, Apr 27, 2017 at 03:43:58PM +0530, Lokesh Vutla wrote: > Instead of defining command options in every defconfig, > define a common Kconfig symbol that consolidates all command > options that are supported by any TI platform. Also use imply > keyword so that that specific option can be disabled if > not required. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/board/ti/common/Kconfig b/board/ti/common/Kconfig index 15b5ccf741..08c39d9409 100644 --- a/board/ti/common/Kconfig +++ b/board/ti/common/Kconfig @@ -13,3 +13,29 @@ config EEPROM_CHIP_ADDRESS hex "Board EEPROM's I2C chip address" range 0 0xff default 0x50 + +config TI_COMMON_CMD_OPTIONS + bool "Enable cmd options on TI platforms" + imply CMD_ASKENV + imply CMD_BOOTZ + imply CMD_DFU if USB_GADGET_DOWNLOAD + imply CMD_DHCP + imply CMD_EXT2 + imply CMD_EXT4 + imply CMD_EXT4_WRITE + imply CMD_FASTBOOT if FASTBOOT + imply CMD_FAT + imply CMD_FS_GENERIC + imply CMD_GPIO + imply CMD_GPT + imply CMD_I2C + imply CMD_MII + imply CMD_MMC + imply CMD_PART + imply CMD_PING + imply CMD_PMIC if DM_PMIC + imply CMD_REGULATOR if DM_REGULATOR + imply CMD_SF if SPI_FLASH + imply CMD_SPI + imply CMD_TIME + imply CMD_USB if USB
Instead of defining command options in every defconfig, define a common Kconfig symbol that consolidates all command options that are supported by any TI platform. Also use imply keyword so that that specific option can be disabled if not required. Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- board/ti/common/Kconfig | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)