| Message ID | 20170426033413.17192-17-famz@redhat.com |
|---|---|
| State | New |
| Headers | show |
Am 26.04.2017 um 05:34 hat Fam Zheng geschrieben: > Making this option available even before implementing it will let > converting tests easier: in coming patches they can specify the option > already when necessary, before we actually write code to lock the > images. > > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > block/file-posix.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/block/file-posix.c b/block/file-posix.c > index ade71db..2114720 100644 > --- a/block/file-posix.c > +++ b/block/file-posix.c > @@ -392,6 +392,11 @@ static QemuOptsList raw_runtime_opts = { > .type = QEMU_OPT_STRING, > .help = "host AIO implementation (threads, native)", > }, > + { > + .name = "locking", > + .type = QEMU_OPT_BOOL, > + .help = "lock the file", > + }, > { /* end of list */ } > }, > }; I don't mind whether it happens in this patch or when the option is actually implemented, but this option needs to be added to the QAPI schema. Kevin
On Wed, 04/26 14:41, Kevin Wolf wrote: > Am 26.04.2017 um 05:34 hat Fam Zheng geschrieben: > > Making this option available even before implementing it will let > > converting tests easier: in coming patches they can specify the option > > already when necessary, before we actually write code to lock the > > images. > > > > Signed-off-by: Fam Zheng <famz@redhat.com> > > --- > > block/file-posix.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/block/file-posix.c b/block/file-posix.c > > index ade71db..2114720 100644 > > --- a/block/file-posix.c > > +++ b/block/file-posix.c > > @@ -392,6 +392,11 @@ static QemuOptsList raw_runtime_opts = { > > .type = QEMU_OPT_STRING, > > .help = "host AIO implementation (threads, native)", > > }, > > + { > > + .name = "locking", > > + .type = QEMU_OPT_BOOL, > > + .help = "lock the file", > > + }, > > { /* end of list */ } > > }, > > }; > > I don't mind whether it happens in this patch or when the option is > actually implemented, but this option needs to be added to the QAPI > schema. I will add it. Fam
diff --git a/block/file-posix.c b/block/file-posix.c index ade71db..2114720 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -392,6 +392,11 @@ static QemuOptsList raw_runtime_opts = { .type = QEMU_OPT_STRING, .help = "host AIO implementation (threads, native)", }, + { + .name = "locking", + .type = QEMU_OPT_BOOL, + .help = "lock the file", + }, { /* end of list */ } }, };
Making this option available even before implementing it will let converting tests easier: in coming patches they can specify the option already when necessary, before we actually write code to lock the images. Signed-off-by: Fam Zheng <famz@redhat.com> --- block/file-posix.c | 5 +++++ 1 file changed, 5 insertions(+)