| Message ID | 6e5e28bc-b89a-931e-be6c-98c2ebb5434f@awox.com |
|---|---|
| State | Rejected |
| Headers | show |
Hello, On Tue, 25 Apr 2017 17:42:16 +0200, Olivier Valentin wrote: > When buildroot has debugging enabled, let libcurl configure > its build accordingly. > > Signed-off-by: Olivier Valentin <ovalentin@awox.com> Thanks, but since commit https://git.buildroot.org/buildroot/commit/?id=0552a367dbdc27a211daaac3359d81dd537e384f, we no longer pass --enable-debug/--disable-debug to packages. Indeed, we have realized that packages are not consistent in what they do when --enable-debug/--disable-debug is passed. So, BR2_ENABLE_DEBUG is nowadays *only* to get packages built with debugging symbols, and this is controlled by adding "-g" to CFLAGS. Best regards, Thomas
diff --git a/package/libcurl/libcurl.mk b/package/libcurl/libcurl.mk index 6f4803e0c..cba771c61 100644 --- a/package/libcurl/libcurl.mk +++ b/package/libcurl/libcurl.mk @@ -22,6 +22,10 @@ LIBCURL_INSTALL_STAGING = YES LIBCURL_CONF_OPTS = --disable-manual --disable-ntlm-wb \ --enable-hidden-symbols --with-random=/dev/urandom --disable-curldebug +ifeq ($(BR2_ENABLE_DEBUG),y) +LIBCURL_CONF_OPTS += --enable-debug +endif + ifeq ($(BR2_PACKAGE_LIBCURL_VERBOSE),y) LIBCURL_CONF_OPTS += --enable-verbose else
When buildroot has debugging enabled, let libcurl configure its build accordingly. Signed-off-by: Olivier Valentin <ovalentin@awox.com> --- package/libcurl/libcurl.mk | 4 ++++ 1 file changed, 4 insertions(+)