| Message ID | 1493106644-6049-1-git-send-email-thuth@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 2017年04月25日 15:50, Thomas Huth wrote: > Network dumping should be done with "-object filter-dump" nowadays. > Using "-net dump" via the VLAN mechanism is considered as deprecated > and might be removed in a future release. So warn the users now > to inform them to user the filter-dump method instead. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > net/dump.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/dump.c b/net/dump.c > index 89a149b..442eb53 100644 > --- a/net/dump.c > +++ b/net/dump.c > @@ -194,6 +194,9 @@ int net_init_dump(const Netdev *netdev, const char *name, > > assert(peer); > > + error_report("'-net dump' is deprecated. " > + "Please use '-object filter-dump' instead."); > + > if (dump->has_file) { > file = dump->file; > } else { Applied. Thanks
diff --git a/net/dump.c b/net/dump.c index 89a149b..442eb53 100644 --- a/net/dump.c +++ b/net/dump.c @@ -194,6 +194,9 @@ int net_init_dump(const Netdev *netdev, const char *name, assert(peer); + error_report("'-net dump' is deprecated. " + "Please use '-object filter-dump' instead."); + if (dump->has_file) { file = dump->file; } else {
Network dumping should be done with "-object filter-dump" nowadays. Using "-net dump" via the VLAN mechanism is considered as deprecated and might be removed in a future release. So warn the users now to inform them to user the filter-dump method instead. Signed-off-by: Thomas Huth <thuth@redhat.com> --- net/dump.c | 3 +++ 1 file changed, 3 insertions(+)