| Message ID | 1292287667.26970.114.camel@Joe-Laptop |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, Dec 13, 2010 at 04:47:47PM -0800, Joe Perches wrote: > LARQ seems to be used by Broadcom's staging driver. > Might as well add a #define for it to the normal location. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > include/linux/if_ether.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h > index f9c3df0..b257e99 100644 > --- a/include/linux/if_ether.h > +++ b/include/linux/if_ether.h > @@ -71,6 +71,8 @@ > #define ETH_P_PPP_SES 0x8864 /* PPPoE session messages */ > #define ETH_P_MPLS_UC 0x8847 /* MPLS Unicast traffic */ > #define ETH_P_MPLS_MC 0x8848 /* MPLS Multicast traffic */ > +#define ETH_P_LARQ 0x886c /* HPNA / Broadcom > + * Limited Automatic Repeat reQuest */ That should be ETH_P_BRCM (or ETH_P_EPIGRAM). HPNA/ILCP used a range of subtypes for LARQ and other HPNA protocols. The brcmfmac driver uses a different subypte for encapsulating some event signals between the device and the host, but doesn't implement any of the HPNA protocols. - Henry -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2010-12-13 at 17:49 -0800, Henry Ptasinski wrote: > On Mon, Dec 13, 2010 at 04:47:47PM -0800, Joe Perches wrote: > > LARQ seems to be used by Broadcom's staging driver. > > Might as well add a #define for it to the normal location. > > diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h [] > > +#define ETH_P_LARQ 0x886c /* HPNA / Broadcom > That should be ETH_P_BRCM (or ETH_P_EPIGRAM). HPNA/ILCP used a range of > subtypes for LARQ and other HPNA protocols. The brcmfmac driver uses a > different subypte for encapsulating some event signals between the device and > the host, but doesn't implement any of the HPNA protocols. Another choice might be ETH_P_LINK_CTL -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Dec 13, 2010 at 07:53:51PM -0800, Joe Perches wrote: > On Mon, 2010-12-13 at 17:49 -0800, Henry Ptasinski wrote: > > On Mon, Dec 13, 2010 at 04:47:47PM -0800, Joe Perches wrote: > > > LARQ seems to be used by Broadcom's staging driver. > > > Might as well add a #define for it to the normal location. > > > diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h > [] > > > +#define ETH_P_LARQ 0x886c /* HPNA / Broadcom > > That should be ETH_P_BRCM (or ETH_P_EPIGRAM). HPNA/ILCP used a range of > > subtypes for LARQ and other HPNA protocols. The brcmfmac driver uses a > > different subypte for encapsulating some event signals between the device and > > the host, but doesn't implement any of the HPNA protocols. > > Another choice might be ETH_P_LINK_CTL > That would be fine too. - Henry -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h index f9c3df0..b257e99 100644 --- a/include/linux/if_ether.h +++ b/include/linux/if_ether.h @@ -71,6 +71,8 @@ #define ETH_P_PPP_SES 0x8864 /* PPPoE session messages */ #define ETH_P_MPLS_UC 0x8847 /* MPLS Unicast traffic */ #define ETH_P_MPLS_MC 0x8848 /* MPLS Multicast traffic */ +#define ETH_P_LARQ 0x886c /* HPNA / Broadcom + * Limited Automatic Repeat reQuest */ #define ETH_P_ATMMPOA 0x884c /* MultiProtocol Over ATM */ #define ETH_P_ATMFATE 0x8884 /* Frame-based ATM Transport * over Ethernet
LARQ seems to be used by Broadcom's staging driver. Might as well add a #define for it to the normal location. Signed-off-by: Joe Perches <joe@perches.com> --- include/linux/if_ether.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html