| Message ID | 20170424200030.2787-1-lmadsen@redhat.com |
|---|---|
| State | Not Applicable |
| Headers | show |
On Mon, Apr 24, 2017 at 04:00:30PM -0400, Leif Madsen wrote: > Remove unneeded manpage globs from the RPM spec file since they > are no longer being generated. > --- > rhel/openvswitch-fedora.spec.in | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in > index dbcab00..1095cd0 100644 > --- a/rhel/openvswitch-fedora.spec.in > +++ b/rhel/openvswitch-fedora.spec.in > @@ -468,8 +468,6 @@ fi > %{_bindir}/ovs-pcap > %{_bindir}/ovs-tcpdump > %{_bindir}/ovs-tcpundump > -%{_mandir}/man8/ovs-test.8* > -%{_mandir}/man8/ovs-vlan-test.8* > %{_mandir}/man8/ovs-l3ping.8* > %{_mandir}/man1/ovs-pcap.1* > %{_mandir}/man8/ovs-tcpdump.8* I'm confused. There was no removal or renaming of the installed man8 pages, only of the source files. So, when I run "make install DESTDIR=$PWD/inst", I get a file inst/usr/share/man/man8/ovs-test.8 installed, and that should be the same as before. Any idea what's going on? Thanks, Ben.
On Mon, Apr 24, 2017 at 4:07 PM, Ben Pfaff <blp@ovn.org> wrote: > On Mon, Apr 24, 2017 at 04:00:30PM -0400, Leif Madsen wrote: > > Remove unneeded manpage globs from the RPM spec file since they > > are no longer being generated. > > --- > > rhel/openvswitch-fedora.spec.in | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora. > spec.in > > index dbcab00..1095cd0 100644 > > --- a/rhel/openvswitch-fedora.spec.in > > +++ b/rhel/openvswitch-fedora.spec.in > > @@ -468,8 +468,6 @@ fi > > %{_bindir}/ovs-pcap > > %{_bindir}/ovs-tcpdump > > %{_bindir}/ovs-tcpundump > > -%{_mandir}/man8/ovs-test.8* > > -%{_mandir}/man8/ovs-vlan-test.8* > > %{_mandir}/man8/ovs-l3ping.8* > > %{_mandir}/man1/ovs-pcap.1* > > %{_mandir}/man8/ovs-tcpdump.8* > > I'm confused. There was no removal or renaming of the installed man8 > pages, only of the source files. So, when I run "make install > DESTDIR=$PWD/inst", I get a file inst/usr/share/man/man8/ovs-test.8 > installed, and that should be the same as before. > > Any idea what's going on? > Fixed by Lance Richardson in another patch. This should be abandoned.
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index dbcab00..1095cd0 100644 --- a/rhel/openvswitch-fedora.spec.in +++ b/rhel/openvswitch-fedora.spec.in @@ -468,8 +468,6 @@ fi %{_bindir}/ovs-pcap %{_bindir}/ovs-tcpdump %{_bindir}/ovs-tcpundump -%{_mandir}/man8/ovs-test.8* -%{_mandir}/man8/ovs-vlan-test.8* %{_mandir}/man8/ovs-l3ping.8* %{_mandir}/man1/ovs-pcap.1* %{_mandir}/man8/ovs-tcpdump.8*