| Message ID | 1493056179-6460-1-git-send-email-karim.eshapa@gmail.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Karim Eshapa <karim.eshapa@gmail.com> Date: Mon, 24 Apr 2017 19:49:39 +0200 > static char pointer creates two variables in final assembly. > static string and pointer to it according to > Jeff Garzik janitors TODO. > > Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com> Instead of trusting some document written more than 10 years ago on the internet, why don't you build the source file in question and take a look at what actually happens? I'm not applying this, sorry.
On Mon, 24 Apr 2017 14:18:58 -0400 (EDT), David Miller wrote: > Mon, 24 Apr 2017 19:49:39 +0200, Karim Eshapa wrote: >> >> static char pointer creates two variables in final assembly. >> static string and pointer to it according to >> Jeff Garzik janitors TODO. > > Instead of trusting some document written more than 10 years ago on > the internet, why don't you build the source file in question and take > a look at what actually happens? > I've just dumped the assembly and symbols. I didn't find extraordinary difference between the two strings. sorry for that, but why is that still there in TODO kerneljanitors at kernelnewbies. Thanks, Karim
From: Karim Eshapa <karim.eshapa@gmail.com> Date: Mon, 24 Apr 2017 21:54:42 +0200 > On Mon, 24 Apr 2017 14:18:58 -0400 (EDT), David Miller wrote: >> Mon, 24 Apr 2017 19:49:39 +0200, Karim Eshapa wrote: >>> >>> static char pointer creates two variables in final assembly. >>> static string and pointer to it according to >>> Jeff Garzik janitors TODO. >> >> Instead of trusting some document written more than 10 years ago on >> the internet, why don't you build the source file in question and take >> a look at what actually happens? >> > > I've just dumped the assembly and symbols. I didn't find > extraordinary difference between the two strings. > sorry for that, but why is that still there in > TODO kerneljanitors at kernelnewbies. Because nobody is updating the documentation.
diff --git a/drivers/net/cris/eth_v10.c b/drivers/net/cris/eth_v10.c index 91c876a..370765f 100644 --- a/drivers/net/cris/eth_v10.c +++ b/drivers/net/cris/eth_v10.c @@ -44,7 +44,7 @@ * io regions, irqs and dma channels */ -static const char* cardname = "ETRAX 100LX built-in ethernet controller"; +static const char cardname[] = "ETRAX 100LX built-in ethernet controller"; /* A default ethernet address. Highlevel SW will set the real one later */
static char pointer creates two variables in final assembly. static string and pointer to it according to Jeff Garzik janitors TODO. Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com> --- drivers/net/cris/eth_v10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)