| Message ID | 1493042662-30435-1-git-send-email-agust@denx.de |
|---|---|
| State | New |
| Headers | show |
On Mon, Apr 24, 2017 at 5:04 PM, Anatolij Gustschin <agust@denx.de> wrote: > Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table() > for the !GPIOLIB case to prevent build errors. Also add prototypes. One nit below, otherwise FWIW: Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Linus, it would be nice if are okay with this approach. It will fix that one user which might break a buiid on some kernel configurations. > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > --- > include/linux/gpio/consumer.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h > index 933d936..6c0cc67 100644 > --- a/include/linux/gpio/consumer.h > +++ b/include/linux/gpio/consumer.h > @@ -144,6 +144,11 @@ struct gpio_desc *devm_fwnode_get_index_gpiod_from_child(struct device *dev, > enum gpiod_flags flags, > const char *label); > +struct gpiod_lookup_table; > #else /* CONFIG_GPIOLIB */ > +struct gpiod_lookup_table; No need to duplicate this. Just move out of #ifdef.
diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h index 933d936..6c0cc67 100644 --- a/include/linux/gpio/consumer.h +++ b/include/linux/gpio/consumer.h @@ -144,6 +144,11 @@ struct gpio_desc *devm_fwnode_get_index_gpiod_from_child(struct device *dev, enum gpiod_flags flags, const char *label); +struct gpiod_lookup_table; + +void gpiod_add_lookup_table(struct gpiod_lookup_table *table); +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table); + #else /* CONFIG_GPIOLIB */ static inline int gpiod_count(struct device *dev, const char *con_id) @@ -435,6 +440,16 @@ struct gpio_desc *devm_fwnode_get_index_gpiod_from_child(struct device *dev, return ERR_PTR(-ENOSYS); } +struct gpiod_lookup_table; + +static inline void gpiod_add_lookup_table(struct gpiod_lookup_table *table) +{ +} + +static inline void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) +{ +} + #endif /* CONFIG_GPIOLIB */ static inline
Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table() for the !GPIOLIB case to prevent build errors. Also add prototypes. Signed-off-by: Anatolij Gustschin <agust@denx.de> --- include/linux/gpio/consumer.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+)