From patchwork Mon Apr 24 10:01:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 754188 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wBMMR05GWz9sDC for ; Mon, 24 Apr 2017 20:02:11 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1168330AbdDXKBy (ORCPT ); Mon, 24 Apr 2017 06:01:54 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:36922 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1166849AbdDXKBm (ORCPT ); Mon, 24 Apr 2017 06:01:42 -0400 Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20170424100140epoutp025dd9d6d65cdf633cd954fede838b5654~4TSWLYPLy0241902419epoutp02E; Mon, 24 Apr 2017 10:01:40 +0000 (GMT) Received: from epsmges1p1.samsung.com (unknown [182.195.42.53]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20170424100139epcas1p3f2ffa5ca2cc2efd94025b0c7e06b8c8e~4TSV6lXFW3192431924epcas1p3a; Mon, 24 Apr 2017 10:01:39 +0000 (GMT) Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p1.samsung.com (Symantec Messaging Gateway) with SMTP id 1F.4C.11252.30DCDF85; Mon, 24 Apr 2017 19:01:39 +0900 (KST) Received: from epsmgms2p1 (unknown [182.195.42.79]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20170424100139epcas1p4e8e120d2da6ef7eb69ca28f6b3077c59~4TSVnfNBy1183911839epcas1p4S; Mon, 24 Apr 2017 10:01:39 +0000 (GMT) X-AuditID: b6c32a35-f79806d000002bf4-f5-58fdcd032211 Received: from epmmp2 ( [203.254.227.17]) by epsmgms2p1 (Symantec Messaging Gateway) with SMTP id 72.2D.24926.30DCDF85; Mon, 24 Apr 2017 19:01:39 +0900 (KST) Received: from AMDC3058.DIGITAL.local ([106.120.53.102]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OOW00J6ZRU89QC0@mmp2.samsung.com>; Mon, 24 Apr 2017 19:01:39 +0900 (KST) From: Bartlomiej Zolnierkiewicz To: Thierry Reding , Jean Delvare , Guenter Roeck , Kamil Debski Cc: Tomasz Figa , linux-pwm@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com Subject: [PATCH v2 3/3] hwmon: pwm-fan: remove no longer needed suspend/resume code Date: Mon, 24 Apr 2017 12:01:09 +0200 Message-id: <1493028069-32003-4-git-send-email-b.zolnierkie@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1493028069-32003-1-git-send-email-b.zolnierkie@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAAzWRb0gTYRzHfXa33W06u6atx2kGiwINtUHSUSEFQRcE6YtgGZKHHjrc3NhN 0XyRpqQukcUkV6z8E5Je0nRO57TE1PJPqZWuN6ZpZZaJEhLin2XNs3ef3+/7/X35Pjw4IvuE KnBNtokxZtNapUiCdvRHxcUgoz71saUJFdlqcwjJUUsSeW+oVEiW/mwH5ESXXUROT3OAtI33 CMivdW8E5HrXQ5TkurbAGQnluT+NUZ61QoyqdHGAcri8KLXqjKQmB4qwRFGy5HQ6o9XkMsa4 hFRJpqV+ARhc0jxbr11QCG4GmoEYh8RxaPcOAp7l8O2MQ2QGElxGdALY1jqL8MMCgFUt25gZ 4DsXs5Yr/L4OwOqZAYwfNgD0PS3H/FEi4iS8U8oBvxBKVAM4PtmD+AWE6AFweczk5xDiMvRs eEV+RonD0PuoEfWzlKDgdtuUiO8UCYdfWYV+FhMXoPvX2k4lSBRjsKjJg/KVDkBnL8L7z8Gt qiUhzyFwcdCF8ayART/mBDz/K+TehHxOG4Bct2XXdAr2D74T8kWD4fLvCiGfL4Vlt2S8hYJu J4fyfBY2Oad2X28HsPx9I2oBEbUggANyxsDqMhhWZVDFsrSOzcnOiE3T65xg59uj4ztB1djF PkDgQBkkbVnfUsuEdC6br+sDEEeUodLbjT61TJpO519njPprxhwtw/aBcBxV7pfuc3xQy4gM 2sRkMYyBMf5XBbhYUQjkgRyXXIvL6+P14oSUoODUQwXz8x5vq7P2RkDFHPIk8uUlV4Hp23BU 72KNtTmneMazR25VndBo5o0Nid/NXJ6vssl6cEWg64h4kBR2/gWdom1+7f6zuqL8ElayOXL0 c3eNIXyjoeJj8tAR/V78KlKW1h5je/Z85HFJ1t28BoUSZTNpVTRiZOm/qqumffICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsVy+t9jQV3ms38jDM52y1lsnLGe1eLshECL mSfaWS3aX29ltLi8aw6bxd27qxgtZpzfx2TxZOEZJoufu+axWKza9YfRgctj56y77B47vzew e/RtWcXosX7LVRaPz5vkPK4caWQPYItys8lITUxJLVJIzUvOT8nMS7dVCg1x07VQUshLzE21 VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW8aERc8ZC7bwVsw4MIepgbGJu4uRg0NCwETi wYTILkZOIFNM4sK99WxdjFwcQgLzGSUWLTjJBOH8YpTYO7GJGaSKTcBKYmL7KkaQhIjAdEaJ GTO3s4I4zAL7GCVWd00BqxIWCJXY/bKdHcRmEVCVuLp4BQuIzSvgIfF/8202iH1yEiePTWYF sTkFPCW2f/wO1isEVPNv8Vq2CYy8CxgZVjFypRYU56bnFhsVGG5iBAb4tsNa/jsYf5yNPsQo wMGoxMPbofg3Qog1say4MvcQowQHs5IIb/cKoBBvSmJlVWpRfnxRaU5q8SFGU6BTJjJLiSbn A6MvryTe0MTSyMTAzMzQyMDYTEmcd0LglwghgfTEktTs1NSC1CKYPiYOTqkGxvDMAxprlhS9 aI1Tl7r2P5Hh9VSGT4V3Z/jPvB/JejGdZcXSBV9ZF+XLL93M3Xsl82nmrreFPvbJlrPTltzm CJywJD79h97nKxmsMzYKTWDdY/Fml55pekRRbNqXG9ply7lqgjVmVXZOPVhetviZsNqMhr0L +Tb73XM1KTXKPn+7TulEzaoOIyWW4oxEQy3mouJEAP4H70mGAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170424100139epcas1p4e8e120d2da6ef7eb69ca28f6b3077c59 X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170424100139epcas1p4e8e120d2da6ef7eb69ca28f6b3077c59 X-RootMTR: 20170424100139epcas1p4e8e120d2da6ef7eb69ca28f6b3077c59 References: <1493028069-32003-1-git-send-email-b.zolnierkie@samsung.com> Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org The suspend/resume is now properly handled by pwm-samsung driver (pwm-fan is currently only used by ARM Exynos boards) and the old code only handles ctx->pwm_value != 0 case. Just remove it. Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Guenter Roeck --- drivers/hwmon/pwm-fan.c | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c index f9af393..9dc40f3 100644 --- a/drivers/hwmon/pwm-fan.c +++ b/drivers/hwmon/pwm-fan.c @@ -302,37 +302,6 @@ static int pwm_fan_remove(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM_SLEEP -static int pwm_fan_suspend(struct device *dev) -{ - struct pwm_fan_ctx *ctx = dev_get_drvdata(dev); - - if (ctx->pwm_value) - pwm_disable(ctx->pwm); - return 0; -} - -static int pwm_fan_resume(struct device *dev) -{ - struct pwm_fan_ctx *ctx = dev_get_drvdata(dev); - struct pwm_args pargs; - unsigned long duty; - int ret; - - if (ctx->pwm_value == 0) - return 0; - - pwm_get_args(ctx->pwm, &pargs); - duty = DIV_ROUND_UP(ctx->pwm_value * (pargs.period - 1), MAX_PWM); - ret = pwm_config(ctx->pwm, duty, pargs.period); - if (ret) - return ret; - return pwm_enable(ctx->pwm); -} -#endif - -static SIMPLE_DEV_PM_OPS(pwm_fan_pm, pwm_fan_suspend, pwm_fan_resume); - static const struct of_device_id of_pwm_fan_match[] = { { .compatible = "pwm-fan", }, {}, @@ -344,7 +313,6 @@ static int pwm_fan_resume(struct device *dev) .remove = pwm_fan_remove, .driver = { .name = "pwm-fan", - .pm = &pwm_fan_pm, .of_match_table = of_pwm_fan_match, }, };