[v2,1/3] pwm: pwm-samsung: remove redundant checks from pwm_samsung_config()

Message ID 1493028069-32003-2-git-send-email-b.zolnierkie@samsung.com
State Accepted
Headers show

Commit Message

Bartlomiej Zolnierkiewicz April 24, 2017, 10:01 a.m.
If the requested period_ns and duty_ns values are identical to
the last programmed ones pwm_samsung_config() returns early and
skips the hardware configuration. The same checks are now done
by the PWM core so the driver specific ones can be removed.

Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
 drivers/pwm/pwm-samsung.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Thierry Reding Aug. 21, 2017, 8:32 a.m. | #1
On Mon, Apr 24, 2017 at 12:01:07PM +0200, Bartlomiej Zolnierkiewicz wrote:
> If the requested period_ns and duty_ns values are identical to
> the last programmed ones pwm_samsung_config() returns early and
> skips the hardware configuration. The same checks are now done
> by the PWM core so the driver specific ones can be removed.
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
>  drivers/pwm/pwm-samsung.c | 3 ---
>  1 file changed, 3 deletions(-)

Applied to for-4.14/drivers, thanks.

Thierry

Patch

diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
index f113cda..9ea7638 100644
--- a/drivers/pwm/pwm-samsung.c
+++ b/drivers/pwm/pwm-samsung.c
@@ -312,9 +312,6 @@  static int pwm_samsung_config(struct pwm_chip *chip, struct pwm_device *pwm,
 	if (period_ns > NSEC_PER_SEC)
 		return -ERANGE;
 
-	if (period_ns == chan->period_ns && duty_ns == chan->duty_ns)
-		return 0;
-
 	tcnt = readl(our_chip->base + REG_TCNTB(pwm->hwpwm));
 	oldtcmp = readl(our_chip->base + REG_TCMPB(pwm->hwpwm));