diff mbox

uboot-tools autobuild failures

Message ID CAOMZO5D8cXv4+TF=kXMwE5_YE_mCKMhgjS+PCAbSkKHkewzSjA@mail.gmail.com
State Superseded
Headers show

Commit Message

Fabio Estevam April 23, 2017, 11:44 p.m. UTC
Hi Matthew,

On Wed, Apr 19, 2017 at 10:55 PM, Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
> It looks like all of these recent failures are because the python swig
> build does a "$(if $(shell which swig 2> /dev/null),_libfdt.so)" to
> determine if the host system has swig and if so, try to build the
> python bindings.  Obviously not taking into account any prefix we'd
> provide to the host/ in out build.
>
> http://autobuild.buildroot.org/?reason=uboot-tools-2017.03
>
> I don't directly have a need for those bindings, would a patch that
> disables this swig detect be reasonable at this point?  Other option
> would be to rewrite how they're doing it to search a prefix path vs
> using the shell's which.  Then work upstreaming of that change.

U-Boot mainline has a fix for this already:
http://git.denx.de/?p=u-boot.git;a=commitdiff;h=9963890b8be1d208035945abc5ba9f77637b6542

My host PC does not have Python 3, so I cannot reproduce this error myself.

Could you please try the attached Buildroot patch?

Regards,

Fabio Estevam

Comments

Matt Weber April 25, 2017, 5:07 p.m. UTC | #1
Fabio

On Sun, Apr 23, 2017 at 6:44 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Matthew,
>
> On Wed, Apr 19, 2017 at 10:55 PM, Matthew Weber
> <matthew.weber@rockwellcollins.com> wrote:
>> It looks like all of these recent failures are because the python swig
>> build does a "$(if $(shell which swig 2> /dev/null),_libfdt.so)" to
>> determine if the host system has swig and if so, try to build the
>> python bindings.  Obviously not taking into account any prefix we'd
>> provide to the host/ in out build.
>>
>> http://autobuild.buildroot.org/?reason=uboot-tools-2017.03
>>
>> I don't directly have a need for those bindings, would a patch that
>> disables this swig detect be reasonable at this point?  Other option
>> would be to rewrite how they're doing it to search a prefix path vs
>> using the shell's which.  Then work upstreaming of that change.
>
> U-Boot mainline has a fix for this already:
> http://git.denx.de/?p=u-boot.git;a=commitdiff;h=9963890b8be1d208035945abc5ba9f77637b6542
>
> My host PC does not have Python 3, so I cannot reproduce this error myself.
>
> Could you please try the attached Buildroot patch?

No luck, same error.  I did notice this seems to be impacted by -j level.

Matt
Fabio Estevam April 25, 2017, 5:09 p.m. UTC | #2
On Tue, Apr 25, 2017 at 2:07 PM, Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:

> No luck, same error.  I did notice this seems to be impacted by -j level.

Please report this error in the U-boot list. Thanks
Matt Weber May 2, 2017, 4:02 a.m. UTC | #3
All,

On Tue, Apr 25, 2017 at 12:09 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Tue, Apr 25, 2017 at 2:07 PM, Matthew Weber
> <matthew.weber@rockwellcollins.com> wrote:
>
>> No luck, same error.  I did notice this seems to be impacted by -j level.
>
> Please report this error in the U-boot list. Thanks

Done and I submitted a workaround for now until a clean fix can be
found upstream.
https://patchwork.ozlabs.org/patch/757382/
diff mbox

Patch

From 9326f106d9492359d8d99829aadd2c434168e5f4 Mon Sep 17 00:00:00 2001
From: Fabio Estevam <festevam@gmail.com>
Date: Sun, 23 Apr 2017 20:36:56 -0300
Subject: [PATCH] uboot-tools: Fix build with Python 3

Apply a mainline U-Boot patch to fix build with Python 3.

Fixes: http://autobuild.buildroot.net/results/d09/d097bf94da09941352c689b8d01ab16ece2c1c85/build-end.log

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 .../0005-libfdt-fix-build-with-Python-3.patch      | 35 ++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 package/uboot-tools/0005-libfdt-fix-build-with-Python-3.patch

diff --git a/package/uboot-tools/0005-libfdt-fix-build-with-Python-3.patch b/package/uboot-tools/0005-libfdt-fix-build-with-Python-3.patch
new file mode 100644
index 0000000..f981cbc
--- /dev/null
+++ b/package/uboot-tools/0005-libfdt-fix-build-with-Python-3.patch
@@ -0,0 +1,35 @@ 
+From 16d97c0928fb8cf6de27f1f13896763eab815a7d Mon Sep 17 00:00:00 2001
+From: Stefan Agner <stefan.agner@toradex.com>
+Date: Sun, 23 Apr 2017 20:32:48 -0300
+Subject: [PATCH] libfdt: fix build with Python 3
+
+For some reason Python 3 seems to think it does not need to build
+the library. Using the --force parameter makes sure that the library
+gets built always. This is especially important since we move the
+library in the next step of the Makefile, hence forcing a rebuild
+every time the higher level Makefile triggers a rebuild is required
+to make sure the library is always there.
+
+Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
+Acked-by: Simon Glass <sjg@chromium.org>
+Signed-off-by: Fabio Estevam <festevam@gmail.com>
+---
+ lib/libfdt/setup.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/lib/libfdt/setup.py b/lib/libfdt/setup.py
+index 62e7bcc..845a0c2 100644
+--- a/lib/libfdt/setup.py
++++ b/lib/libfdt/setup.py
+@@ -27,7 +27,7 @@ libfdt_module = Extension(
+     extra_compile_args =  cflags
+ )
+ 
+-sys.argv = [progname, '--quiet', 'build_ext', '--inplace']
++sys.argv = [progname, '--quiet', 'build_ext', '--inplace', '--force']
+ 
+ setup (name = 'libfdt',
+        version = '0.1',
+-- 
+2.7.4
+
-- 
2.7.4