| Message ID | 20170422210539.5750-1-yann.morin.1998@free.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
All, On 2017-04-22 23:05 +0200, Yann E. MORIN spake thusly: > Since XBMC was renamed to Kodi, upstream is progressively propagating > the rename to directories and files, and in some cases kept a legacy > symlink xbmc->kodi, like /usr/lib/xbmc pointing to /usr/lib/kodi. > > In 62165ae (package/kodi: Fix path to binary in service), the path nary s/ nary$// Not sure what hapenned... Regards, Yann E. MORIN. > was changed to use the new canonical path, but the init script was eft > out. This was not seen previously, becasue of the legacy symlink. > > But with the adevent of Kodi 17 (Krypton), that legacy symlink is no > more, and the init script no longer works. > > Do for the init script what was done two years ago for the service file. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> > Cc: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/kodi/S50kodi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/kodi/S50kodi b/package/kodi/S50kodi > index f00c59c5d9..0afe7a6706 100755 > --- a/package/kodi/S50kodi > +++ b/package/kodi/S50kodi > @@ -4,7 +4,7 @@ > # > > BIN=/usr/bin/br-kodi > -KODI=/usr/lib/xbmc/kodi.bin > +KODI=/usr/lib/kodi/kodi.bin > KODI_ARGS="--standalone -fs -n" > PIDFILE=/var/run/kodi.pid > > -- > 2.11.0 >
Am Sat, 22 Apr 2017 23:05:39 +0200 schrieb Yann E. MORIN: > Since XBMC was renamed to Kodi, upstream is progressively propagating > the rename to directories and files, and in some cases kept a legacy > symlink xbmc->kodi, like /usr/lib/xbmc pointing to /usr/lib/kodi. > > In 62165ae (package/kodi: Fix path to binary in service), the path nary > was changed to use the new canonical path, but the init script was eft > out. This was not seen previously, becasue of the legacy symlink. > > But with the adevent of Kodi 17 (Krypton), that legacy symlink is no > more, and the init script no longer works. > > Do for the init script what was done two years ago for the service file. > > Signed-off-by: "Yann E. MORIN" > <yann.morin.1998@free.fr> Cc: Maxime Hadjinlian > <maxime.hadjinlian@gmail.com> > Cc: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/kodi/S50kodi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/kodi/S50kodi b/package/kodi/S50kodi index > f00c59c5d9..0afe7a6706 100755 --- a/package/kodi/S50kodi +++ > b/package/kodi/S50kodi @@ -4,7 +4,7 @@ > # > > BIN=/usr/bin/br-kodi > -KODI=/usr/lib/xbmc/kodi.bin +KODI=/usr/lib/kodi/kodi.bin > KODI_ARGS="--standalone -fs -n" PIDFILE=/var/run/kodi.pid Reviewed-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Hey Yann, On 22.04.2017 23:05, Yann E. MORIN wrote: > Since XBMC was renamed to Kodi, upstream is progressively propagating > the rename to directories and files, and in some cases kept a legacy > symlink xbmc->kodi, like /usr/lib/xbmc pointing to /usr/lib/kodi. > > In 62165ae (package/kodi: Fix path to binary in service), the path nary > was changed to use the new canonical path, but the init script was eft Another typo here 'eft'. > out. This was not seen previously, becasue of the legacy symlink. > > But with the adevent of Kodi 17 (Krypton), that legacy symlink is no And here 'adevent'. > [...] Best wishes, Marcus
Marcus, All, On 2017-04-22 23:22 +0200, Marcus Hoffmann spake thusly: > On 22.04.2017 23:05, Yann E. MORIN wrote: > > Since XBMC was renamed to Kodi, upstream is progressively propagating > > the rename to directories and files, and in some cases kept a legacy > > symlink xbmc->kodi, like /usr/lib/xbmc pointing to /usr/lib/kodi. > > > > In 62165ae (package/kodi: Fix path to binary in service), the path nary > > was changed to use the new canonical path, but the init script was eft > > Another typo here 'eft'. > > > out. This was not seen previously, becasue of the legacy symlink. > > > > But with the adevent of Kodi 17 (Krypton), that legacy symlink is no > > And here 'adevent'. Thanks, I'll respin. Regards, Yann E. MORIN.
diff --git a/package/kodi/S50kodi b/package/kodi/S50kodi index f00c59c5d9..0afe7a6706 100755 --- a/package/kodi/S50kodi +++ b/package/kodi/S50kodi @@ -4,7 +4,7 @@ # BIN=/usr/bin/br-kodi -KODI=/usr/lib/xbmc/kodi.bin +KODI=/usr/lib/kodi/kodi.bin KODI_ARGS="--standalone -fs -n" PIDFILE=/var/run/kodi.pid
Since XBMC was renamed to Kodi, upstream is progressively propagating the rename to directories and files, and in some cases kept a legacy symlink xbmc->kodi, like /usr/lib/xbmc pointing to /usr/lib/kodi. In 62165ae (package/kodi: Fix path to binary in service), the path nary was changed to use the new canonical path, but the init script was eft out. This was not seen previously, becasue of the legacy symlink. But with the adevent of Kodi 17 (Krypton), that legacy symlink is no more, and the init script no longer works. Do for the init script what was done two years ago for the service file. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> Cc: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/kodi/S50kodi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)