| Message ID | 18f3784fe7bf463595f7261fb4e8e9fd6548b0d5.1492815938.git.shuahkh@osg.samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Shuah Khan <shuahkh@osg.samsung.com> writes: > Add override for lib.mk clean to fix the following warnings from clean > target run. > > Makefile:8: warning: overriding recipe for target 'clean' > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > --- > tools/testing/selftests/splice/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/splice/Makefile b/tools/testing/selftests/splice/Makefile > index 559512c..3f967ba 100644 > --- a/tools/testing/selftests/splice/Makefile > +++ b/tools/testing/selftests/splice/Makefile > @@ -4,5 +4,6 @@ all: $(TEST_PROGS) $(EXTRA) > > include ../lib.mk > > -clean: > +override define CLEAN > rm -fr $(EXTRA) > +endef Could just be: EXTRA_CLEAN := $(EXTRA) cheers
On 04/21/2017 11:40 PM, Michael Ellerman wrote: > Shuah Khan <shuahkh@osg.samsung.com> writes: > >> Add override for lib.mk clean to fix the following warnings from clean >> target run. >> >> Makefile:8: warning: overriding recipe for target 'clean' >> ../lib.mk:55: warning: ignoring old recipe for target 'clean' >> >> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> >> --- >> tools/testing/selftests/splice/Makefile | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/splice/Makefile b/tools/testing/selftests/splice/Makefile >> index 559512c..3f967ba 100644 >> --- a/tools/testing/selftests/splice/Makefile >> +++ b/tools/testing/selftests/splice/Makefile >> @@ -4,5 +4,6 @@ all: $(TEST_PROGS) $(EXTRA) >> >> include ../lib.mk >> >> -clean: >> +override define CLEAN >> rm -fr $(EXTRA) >> +endef > > Could just be: > > EXTRA_CLEAN := $(EXTRA) > Will send v2 with this change. -- Shuah
diff --git a/tools/testing/selftests/splice/Makefile b/tools/testing/selftests/splice/Makefile index 559512c..3f967ba 100644 --- a/tools/testing/selftests/splice/Makefile +++ b/tools/testing/selftests/splice/Makefile @@ -4,5 +4,6 @@ all: $(TEST_PROGS) $(EXTRA) include ../lib.mk -clean: +override define CLEAN rm -fr $(EXTRA) +endef
Add override for lib.mk clean to fix the following warnings from clean target run. Makefile:8: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> --- tools/testing/selftests/splice/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)