| Message ID | 31b94c5cb9a8f71fd3888b648f32c0bd91e4a9bd.1492815938.git.shuahkh@osg.samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Shuah Khan <shuahkh@osg.samsung.com> writes: > Add override for lib.mk clean to fix the following warnings from clean > target run. > > Makefile:44: warning: overriding recipe for target 'clean' > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > --- > tools/testing/selftests/x86/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile > index 38e0a9c..4d27550 100644 > --- a/tools/testing/selftests/x86/Makefile > +++ b/tools/testing/selftests/x86/Makefile > @@ -40,8 +40,9 @@ all_32: $(BINARIES_32) > > all_64: $(BINARIES_64) > > -clean: > +override define CLEAN > $(RM) $(BINARIES_32) $(BINARIES_64) > +endef Simpler as: EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64) cheers
From: Linuxppc-dev Michael Ellerman > Shuah Khan <shuahkh@osg.samsung.com> writes: > > > Add override for lib.mk clean to fix the following warnings from clean > > target run. > > > > Makefile:44: warning: overriding recipe for target 'clean' > > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > > > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > > --- > > tools/testing/selftests/x86/Makefile | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile > > index 38e0a9c..4d27550 100644 > > --- a/tools/testing/selftests/x86/Makefile > > +++ b/tools/testing/selftests/x86/Makefile > > @@ -40,8 +40,9 @@ all_32: $(BINARIES_32) > > > > all_64: $(BINARIES_64) > > > > -clean: > > +override define CLEAN > > $(RM) $(BINARIES_32) $(BINARIES_64) > > +endef > > Simpler as: > > EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64) Actually for builds that insist on crapping all over the source tree I've used: clean: rm -rf `cat .cvsignore 2>/dev/null` David
On 04/24/2017 09:57 AM, David Laight wrote: > From: Linuxppc-dev Michael Ellerman >> Shuah Khan <shuahkh@osg.samsung.com> writes: >> >>> Add override for lib.mk clean to fix the following warnings from clean >>> target run. >>> >>> Makefile:44: warning: overriding recipe for target 'clean' >>> ../lib.mk:55: warning: ignoring old recipe for target 'clean' >>> >>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> >>> --- >>> tools/testing/selftests/x86/Makefile | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile >>> index 38e0a9c..4d27550 100644 >>> --- a/tools/testing/selftests/x86/Makefile >>> +++ b/tools/testing/selftests/x86/Makefile >>> @@ -40,8 +40,9 @@ all_32: $(BINARIES_32) >>> >>> all_64: $(BINARIES_64) >>> >>> -clean: >>> +override define CLEAN >>> $(RM) $(BINARIES_32) $(BINARIES_64) >>> +endef >> >> Simpler as: >> >> EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64) > > Actually for builds that insist on crapping all over the source tree I've used: > > clean: > rm -rf `cat .cvsignore 2>/dev/null` > > David This will have to be done as a separate change. The warnings I am fixing are related to common clean target in lib.mk and the need to override. thanks, -- Shuah
On 04/21/2017 11:41 PM, Michael Ellerman wrote: > Shuah Khan <shuahkh@osg.samsung.com> writes: > >> Add override for lib.mk clean to fix the following warnings from clean >> target run. >> >> Makefile:44: warning: overriding recipe for target 'clean' >> ../lib.mk:55: warning: ignoring old recipe for target 'clean' >> >> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> >> --- >> tools/testing/selftests/x86/Makefile | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile >> index 38e0a9c..4d27550 100644 >> --- a/tools/testing/selftests/x86/Makefile >> +++ b/tools/testing/selftests/x86/Makefile >> @@ -40,8 +40,9 @@ all_32: $(BINARIES_32) >> >> all_64: $(BINARIES_64) >> >> -clean: >> +override define CLEAN >> $(RM) $(BINARIES_32) $(BINARIES_64) >> +endef > > Simpler as: > > EXTRA_CLEAN := $(BINARIES_32) $(BINARIES_64) > Will send v2 with this change. thanks, -- Shuah
diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile index 38e0a9c..4d27550 100644 --- a/tools/testing/selftests/x86/Makefile +++ b/tools/testing/selftests/x86/Makefile @@ -40,8 +40,9 @@ all_32: $(BINARIES_32) all_64: $(BINARIES_64) -clean: +override define CLEAN $(RM) $(BINARIES_32) $(BINARIES_64) +endef $(BINARIES_32): $(OUTPUT)/%_32: %.c $(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl -lm
Add override for lib.mk clean to fix the following warnings from clean target run. Makefile:44: warning: overriding recipe for target 'clean' ../lib.mk:55: warning: ignoring old recipe for target 'clean' Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> --- tools/testing/selftests/x86/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)