| Message ID | CAA85sZumYPfUg_yA=5azrHneqq-XBmHiGNgRaEvBwbewVRj11w@mail.gmail.com |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Ian Kumlien <ian.kumlien@gmail.com> Date: Fri, 21 Apr 2017 21:45:00 +0200 > The mellanox driver supports both ethernet and infiniband, but it > is located in the ethernet drivers - the ethernet support should > default to 'yes'. I don't have that card and I therefore perhaps don't want that driver in my builds. This is not an appropriate change, sorry.
On Fri, Apr 21, 2017 at 9:47 PM, David Miller <davem@davemloft.net> wrote: > From: Ian Kumlien <ian.kumlien@gmail.com> > Date: Fri, 21 Apr 2017 21:45:00 +0200 > >> The mellanox driver supports both ethernet and infiniband, but it >> is located in the ethernet drivers - the ethernet support should >> default to 'yes'. > > I don't have that card and I therefore perhaps don't want that driver > in my builds. Ah, sorry - really tired here, got it in to my head that this was just a flag for the driver to build the ethernet module, sorry > This is not an appropriate change, sorry. Nope, completely agree... sorry for the noise
From 19bc8a18fe793177e753589ffd69992434f38348 Mon Sep 17 00:00:00 2001 From: Ian Kumlien <ian.kumlien@gmail.com> Date: Fri, 21 Apr 2017 21:30:30 +0200 Subject: [PATCH] Switch mlx5_en default configiuration value The mellanox driver supports both ethernet and infiniband, but it is located in the ethernet drivers - the ethernet support should default to 'yes'. Signed-off-by: Ian Kumlien <ian.kumlien@gmail.com> --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig index ddb4ca4ff930..206894f06dec 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig @@ -15,7 +15,7 @@ config MLX5_CORE_EN bool "Mellanox Technologies ConnectX-4 Ethernet support" depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE imply PTP_1588_CLOCK - default n + default y ---help--- Ethernet support in Mellanox Technologies ConnectX-4 NIC. -- 2.12.2
Hi, For some reason I spend some hours, two days in a row, trying to debug why a newer kernel didn't work on our machines. It worked just fine with the older kernel... And there was no network interfaces to see or try to figure out what was going on with. Playing with the infiniband tools all i could see was things like: ... state: 1: DOWN phys state: 3: Disabled cat: /sys/class/infiniband/mlx5_0/ports/1/rate: Invalid argument rate: unknown link_layer: Ethernet ... It turns out that the kernel was compiled with mlx5_en disabled, since it's the default Unless there is a really good reason not to, lets change the default value to 'y' =) I'm hoping that this will lead to others not experiencing the same surreal journey of trying to debug this ;) ---- The mellanox driver supports both ethernet and infiniband, but it is located in the ethernet drivers - the ethernet support should default to 'yes'. Signed-off-by: Ian Kumlien <ian.kumlien@gmail.com> --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)