From patchwork Fri Apr 21 02:43:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andreas_F=C3=A4rber?= X-Patchwork-Id: 753085 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3w8KnF75Ddz9s2x for ; Fri, 21 Apr 2017 12:44:01 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id A71F9C21DA5; Fri, 21 Apr 2017 02:43:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 5BF51C21C57; Fri, 21 Apr 2017 02:43:47 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id EFBAEC21C57; Fri, 21 Apr 2017 02:43:45 +0000 (UTC) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by lists.denx.de (Postfix) with ESMTPS id 8506AC21C31 for ; Fri, 21 Apr 2017 02:43:45 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3CF66AB9F; Fri, 21 Apr 2017 02:43:45 +0000 (UTC) To: Simon Glass References: <20170417222227.GC19487@bill-the-cat> <1c3b7a48-ad36-8b48-87cb-0c99495b466a@suse.de> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <80b17232-2d00-f253-3cca-fccc1e606bd4@suse.de> Date: Fri, 21 Apr 2017 04:43:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Cc: U-Boot Mailing List Subject: Re: [U-Boot] [ANN] U-Boot v2017.05-rc2 released X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Am 21.04.2017 um 04:24 schrieb Andreas Färber: > Hi Simon, > > Am 21.04.2017 um 04:10 schrieb Simon Glass: >> On 20 April 2017 at 18:47, Andreas Färber wrote: >>> Am 21.04.2017 um 02:34 schrieb Andreas Färber: >>>> Am 21.04.2017 um 01:44 schrieb Simon Glass: >>>>> On 20 April 2017 at 17:23, Andreas Färber wrote: >>>>>> Using -rc2 with firefly-rk3288 defconfig I can only boot into SPL but >>>>>> not into full U-Boot. I am using the old documented way of dd'ing to >>>>>> sector 256 on SD (doc/README.rockchip). >>>>>> >>>>>> Looking at include/configs/rk3288_common.h I also tried putting >>>>>> u-boot.img on a FAT partition, to no effect. >>>>>> >>>>>> v2017.03 doesn't even show SPL working. >>>>>> v2017.01 worked okay. >>>>>> >>>>>> Build log for -rc2: >>>>>> https://build.opensuse.org/build/Base:System:Staging/openSUSE_Factory_ARM/armv7l/u-boot-firefly-rk3288/_log >>>>> >>>>> Can you try removing RETURN_TO_BROM (or imilsar) and adding >>>>> CONFIG_SPL_OF_PLATDATA? >>>> >>>> As an interim update I can share that latest master behaves slightly >>>> differently: >>>> >>>> U-Boot SPL 2017.05-rc2-00053-g3c476d8 (Apr 21 2017 - 02:29:48) >>>> Returning to boot ROM... >>>> >>>> compared to: >>>> >>>> U-Boot SPL 2017.05-rc2 (Apr 20 2017 - 14:33:20) >>> >>> Disabling the ROCKCHIP_SPL_BACK_TO_BROM option I get: >>> >>> U-Boot SPL 2017.05-rc2-00053-g3c476d8 (Apr 21 2017 - 02:38:52) >>> SPL: Unsupported Boot Device! >>> SPL: failed to boot from all boot devices >>> ### ERROR ### Please RESET the board ### >>> >>> If I additionally enable SPL_OF_PLATDATA then I am back to the v2017.03 >>> state of no serial output. >> >> I just tested mainline with those two changes and it works for me. I >> pushed my patch to u-boot-rockchip/firefly-working. Can you try again? > > Confirming that with your defconfig it fully works again. > > I had instead run menuconfig and manually (un)selected the options. > Maybe those options influence other defaults? I was at the same qoriq > merge commit your branch is based off. Here's a quick diff against master: CONFIG_NET_RANDOM_ETHADDR=y # CONFIG_NETCONSOLE is not set @@ -848,6 +847,7 @@ # CONFIG_FSL_LPUART is not set # CONFIG_MVEBU_A3700_UART is not set CONFIG_SYS_NS16550=y +CONFIG_ROCKCHIP_SERIAL=y # CONFIG_MSM_SERIAL is not set # CONFIG_PXA_SERIAL is not set At least SERIAL looks important... Regards, Andreas diff -u firefly/.config firefly/simon_config --- firefly/.config 2017-04-21 04:39:49.484215791 +0200 +++ firefly/simon_config 2017-04-21 04:39:07.123727380 +0200 @@ -169,9 +169,8 @@ CONFIG_ROCKCHIP_RK3288=y # CONFIG_ROCKCHIP_RK3328 is not set # CONFIG_ROCKCHIP_RK3399 is not set -CONFIG_ROCKCHIP_SPL_BACK_TO_BROM=y -CONFIG_ROCKCHIP_BROM_HELPER=y -# CONFIG_SPL_MMC_SUPPORT is not set +# CONFIG_ROCKCHIP_SPL_BACK_TO_BROM is not set +CONFIG_SPL_MMC_SUPPORT=y CONFIG_SPL_SERIAL_SUPPORT=y CONFIG_BOARD_SPECIFIC_OPTIONS=y # CONFIG_TARGET_CHROMEBOOK_JERRY is not set @@ -510,7 +509,7 @@ CONFIG_OF_SEPARATE=y # CONFIG_OF_EMBED is not set CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents" -# CONFIG_SPL_OF_PLATDATA is not set +CONFIG_SPL_OF_PLATDATA=y CONFIG_NET=y