From patchwork Fri Apr 21 00:39:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Zhou X-Patchwork-Id: 753047 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w8H2K70RRz9s7j for ; Fri, 21 Apr 2017 10:40:09 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id DBC9AA88; Fri, 21 Apr 2017 00:40:05 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 03133A6E for ; Fri, 21 Apr 2017 00:40:05 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-io0-f196.google.com (mail-io0-f196.google.com [209.85.223.196]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 7CFFA13A for ; Fri, 21 Apr 2017 00:40:04 +0000 (UTC) Received: by mail-io0-f196.google.com with SMTP id h41so23040835ioi.1 for ; Thu, 20 Apr 2017 17:40:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id :content-transfer-encoding; bh=VACB2ESso+wREVBfi8wgxmuvMLi5uQ49wud0y6t914k=; b=Lp+Q97avKREUZ93zTvyksSyyyP3dchjqxTBRgot0L9430HunVztnz7u+7cixo3ky5A 8J5UIax5icpbQ9G/PuvqbZsi8e3MDnYZq+WnjiJ9NAwzBTnf82aKdrmy9VpAGiX3BTZi EMSgXJIwu3h0p41e0SD4z34Pb+l7lCalr2T8yx13qzYc/3WyP3IfCrOa1zLeFXqjmSdO Gdo40euwfuv/H49BqXpb5B+bgnIr9DZ0u7z4YdWDrq3VCLOfhF3lLdYJ5gDOITdvILQT FM+jpT9/h0Byi1VqwSR/0Sr4dAPe1rlR+lIkVrcE7IcwMbhW0S4LIvYadoWDKenYu+rt DjMw== X-Gm-Message-State: AN3rC/5DB8F149I3+bV+Db27NIyEIH8D7z8DEv5LIF1f47toKwCQ3Hck Zisyxxd6l1N4PQ== X-Received: by 10.98.105.199 with SMTP id e190mr9917912pfc.87.1492735203803; Thu, 20 Apr 2017 17:40:03 -0700 (PDT) Received: from centos.eng.vmware.com ([208.91.1.34]) by smtp.gmail.com with ESMTPSA id c3sm12425708pfg.46.2017.04.20.17.40.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Apr 2017 17:40:03 -0700 (PDT) From: Andy Zhou To: dev@openvswitch.org Date: Thu, 20 Apr 2017 17:39:44 -0700 Message-Id: <1492735184-7730-1-git-send-email-azhou@ovn.org> X-Mailer: git-send-email 1.8.3.1 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH] bridge: Log interface deletion X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Currently, interface additions are logged but not deletion. This makes system debugging, such as confirming OVSDB transaction are timely replicated harder than necessary. Signed-off-by: Andy Zhou Acked-by: Jarno Rajahalme --- vswitchd/bridge.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 867a26d8de19..81bd8074e593 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -4317,6 +4317,9 @@ iface_destroy__(struct iface *iface) struct port *port = iface->port; struct bridge *br = port->bridge; + VLOG_INFO("bridge %s: deleted interface %s on port %d", + br->name, iface->name, iface->ofp_port); + if (br->ofproto && iface->ofp_port != OFPP_NONE) { ofproto_port_unregister(br->ofproto, iface->ofp_port); }