[ovs-dev] bridge: Log interface deletion

Submitted by andy zhou on April 21, 2017, 12:39 a.m.

Details

Message ID 1492735184-7730-1-git-send-email-azhou@ovn.org
State New
Headers show

Commit Message

andy zhou April 21, 2017, 12:39 a.m.
Currently, interface additions are logged but not deletion. This
makes system debugging, such as confirming OVSDB transaction are
timely replicated harder than necessary.

Signed-off-by: Andy Zhou <azhou@ovn.org>
---
 vswitchd/bridge.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Jarno Rajahalme April 21, 2017, 1:18 a.m.
Acked-by: Jarno Rajahalme <jarno@ovn.org>

> On Apr 20, 2017, at 5:39 PM, Andy Zhou <azhou@ovn.org> wrote:
> 
> Currently, interface additions are logged but not deletion. This
> makes system debugging, such as confirming OVSDB transaction are
> timely replicated harder than necessary.
> 
> Signed-off-by: Andy Zhou <azhou@ovn.org>
> ---
> vswitchd/bridge.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index 867a26d8de19..81bd8074e593 100644
> --- a/vswitchd/bridge.c
> +++ b/vswitchd/bridge.c
> @@ -4317,6 +4317,9 @@ iface_destroy__(struct iface *iface)
>         struct port *port = iface->port;
>         struct bridge *br = port->bridge;
> 
> +        VLOG_INFO("bridge %s: deleted interface %s on port %d",
> +                  br->name, iface->name, iface->ofp_port);
> +
>         if (br->ofproto && iface->ofp_port != OFPP_NONE) {
>             ofproto_port_unregister(br->ofproto, iface->ofp_port);
>         }
> -- 
> 1.8.3.1
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
andy zhou April 21, 2017, 7:10 p.m.
On Thu, Apr 20, 2017 at 6:18 PM, Jarno Rajahalme <jarno@ovn.org> wrote:
> Acked-by: Jarno Rajahalme <jarno@ovn.org>

Thanks for the review. Pushed to master, branch 2.5 - 2.7.

Patch hide | download patch | download mbox

diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 867a26d8de19..81bd8074e593 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -4317,6 +4317,9 @@  iface_destroy__(struct iface *iface)
         struct port *port = iface->port;
         struct bridge *br = port->bridge;
 
+        VLOG_INFO("bridge %s: deleted interface %s on port %d",
+                  br->name, iface->name, iface->ofp_port);
+
         if (br->ofproto && iface->ofp_port != OFPP_NONE) {
             ofproto_port_unregister(br->ofproto, iface->ofp_port);
         }