diff mbox

[1/2] package/libpng: Cleanup neon support options

Message ID 20170420213302.31155-1-bernd.kuhls@t-online.de
State Superseded
Headers show

Commit Message

Bernd Kuhls April 20, 2017, 9:33 p.m. UTC
Suggested by Thomas:
http://lists.busybox.net/pipermail/buildroot/2017-April/189086.html

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/libpng/libpng.mk | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Thomas Petazzoni April 21, 2017, 8:04 a.m. UTC | #1
Hello,

On Thu, 20 Apr 2017 23:33:01 +0200, Bernd Kuhls wrote:

> +ifeq ($(BR2_ARM_CPU_HAS_NEON),y)
> +LIBPNG_CONF_OPTS += --enable-arm-neon=yes

Well, my suggestion was to use just --enable-arm-neon, not
--enable-arm-neon=yes.

Best regards,

Thomas
diff mbox

Patch

diff --git a/package/libpng/libpng.mk b/package/libpng/libpng.mk
index 249115702..4272f4e38 100644
--- a/package/libpng/libpng.mk
+++ b/package/libpng/libpng.mk
@@ -14,7 +14,12 @@  LIBPNG_INSTALL_STAGING = YES
 LIBPNG_DEPENDENCIES = host-pkgconf zlib
 HOST_LIBPNG_DEPENDENCIES = host-pkgconf host-zlib
 LIBPNG_CONFIG_SCRIPTS = libpng$(LIBPNG_SERIES)-config libpng-config
-LIBPNG_CONF_OPTS = $(if $(BR2_ARM_CPU_HAS_NEON),--enable-arm-neon=yes,--enable-arm-neon=no)
+
+ifeq ($(BR2_ARM_CPU_HAS_NEON),y)
+LIBPNG_CONF_OPTS += --enable-arm-neon=yes
+else
+LIBPNG_CONF_OPTS += --disable-arm-neon
+endif
 
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))