From patchwork Thu Apr 20 15:41:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Wilco Dijkstra X-Patchwork-Id: 752855 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w83554mWTz9s4s for ; Fri, 21 Apr 2017 01:41:45 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="U55wpkD9"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; q=dns; s= default; b=xNZB2TxPbN8QNRuJKT0ZMN4CxgqfG2Lr0+1TYAHvJwMxzApecWelv jojPiG5PWdc66Sgvkn0GqENH5E9Hdi9kdUITZCSH5cQtW3vIbwmfyFhLX44BkE0I 5ZXzzOgZYMyEeE03LHbFuXDKRlN/ho651FbXf4lYYnauFsQlo8c3/4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s=default; bh=NOWDhMvgsS1mD9YBObcZZs3MTJE=; b=U55wpkD9EJCxi7y0uEakozgOiDpo SAUzUWL/R7DgmOIvE6Xi/tFFTYOK7WbTmxJHasZxoYWirKelJGFnsb4S/EFuPNRB RkfbPfXHyXEG/mhdC/OQ7L6AOZ8vKA679Sc8031mfhYKP3p85NZWlga0z/mCPzCn k7YntqOkrcZsS1s= Received: (qmail 65868 invoked by alias); 20 Apr 2017 15:41:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 65816 invoked by uid 89); 20 Apr 2017 15:41:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1459 X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0047.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Apr 2017 15:41:30 +0000 Received: from AM5PR0802MB2610.eurprd08.prod.outlook.com (10.175.46.18) by DB6PR08MB2664.eurprd08.prod.outlook.com (10.175.234.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13; Thu, 20 Apr 2017 15:41:29 +0000 Received: from AM5PR0802MB2610.eurprd08.prod.outlook.com ([10.175.46.18]) by AM5PR0802MB2610.eurprd08.prod.outlook.com ([10.175.46.18]) with mapi id 15.01.1047.013; Thu, 20 Apr 2017 15:41:29 +0000 From: Wilco Dijkstra To: GCC Patches , James Greenhalgh CC: nd Subject: Re: [PATCH][AArch64] Enable AUTOPREFETCHER_WEAK with -mcpu=generic Date: Thu, 20 Apr 2017 15:41:29 +0000 Message-ID: References: In-Reply-To: authentication-results: arm.com; dkim=none (message not signed) header.d=none; arm.com; dmarc=none action=none header.from=arm.com; x-microsoft-exchange-diagnostics: 1; DB6PR08MB2664; 7:QJcD+CnNs9A17kjrptKNbPB1Mk6aR/iqixXbjO3dLIIzsDqjd3Hy3KMnluCFJza+S7bt523cFNPbe22kGjCz1SHnIKNmbe4nlaqGdvzBX1brV47JGwJdQuqUqgydg+B2pBCLowdomIKozynTi4kI/xKQyfY/vSzJwrtmyR8+4jJ2muD93vQSnPgbmCYmzml3/a+vr2fHzk5UrgDuyycJY5epZy+y/foafoO/OMB8CmEzLXgylehkBrBhYThNu4Pj4zicbX2iCveyVm3i9veiWsnRkYPbiswgNAidtn5nVpB/oTapddiOgZJcGNnOiWZFo4UEvbWfQkZGPMP1CvdkCQ== x-ms-office365-filtering-correlation-id: 97895d1d-2be0-4db5-560a-08d48803b660 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:DB6PR08MB2664; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(20161123564025)(20161123555025)(6072148); SRVR:DB6PR08MB2664; BCL:0; PCL:0; RULEID:; SRVR:DB6PR08MB2664; x-forefront-prvs: 02830F0362 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39860400002)(39850400002)(39450400003)(39400400002)(39840400002)(377424004)(6246003)(229853002)(55016002)(86362001)(6636002)(99286003)(7696004)(66066001)(966004)(53936002)(189998001)(5660300001)(9686003)(6306002)(2950100002)(6506006)(102836003)(33656002)(54356999)(76176999)(3846002)(6116002)(53546009)(2900100001)(77096006)(50986999)(74316002)(81166006)(8676002)(8936002)(3660700001)(122556002)(3280700002)(2906002)(305945005)(4326008)(38730400002)(7736002)(25786009)(41533002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR08MB2664; H:AM5PR0802MB2610.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2017 15:41:29.0457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2664 ping From: Wilco Dijkstra Sent: 05 April 2017 13:38 To: GCC Patches Cc: nd; James Greenhalgh; Andrew.pinski@cavium.com; Evandro Menezes; jim.wilson@linaro.org Subject: [PATCH][AArch64] Enable AUTOPREFETCHER_WEAK with -mcpu=generic   Many supported cores use the AUTOPREFETCHER_WEAK setting which tries to order loads and stores to improve streaming performance.  Since significant gains were reported in http://patchwork.ozlabs.org/patch/534469/ it seems like a good idea to enable this setting too for -mcpu=generic.  Since the weak model only keeps the order if it doesn't make the schedule worse, it should not impact performance adversely on cores that don't show a gain. Any objections? ChangeLog: 2017-04-05  Wilco Dijkstra          * gcc/config/aarch64/aarch64.c (generic_tunings): Update prefetch model. diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 8b729b1b1f87316e940d7fc657f235a935ffa93e..b249ce2b310707c7ded2827d505ce2ddfcfbf976 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -547,7 +547,7 @@ static const struct tune_params generic_tunings =    2,   /* min_div_recip_mul_df.  */    0,   /* max_case_values.  */    0,   /* cache_line_size.  */ -  tune_params::AUTOPREFETCHER_OFF,     /* autoprefetcher_model.  */ +  tune_params::AUTOPREFETCHER_WEAK,    /* autoprefetcher_model.  */    (AARCH64_EXTRA_TUNE_NONE)    /* tune_flags.  */  };