From patchwork Thu Apr 20 12:00:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Herrenschmidt X-Patchwork-Id: 752757 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w7yBW4t3gz9s2x for ; Thu, 20 Apr 2017 22:01:07 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3w7yBW4B3FzDqJL for ; Thu, 20 Apr 2017 22:01:07 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3w7yBR43x0zDq9D for ; Thu, 20 Apr 2017 22:01:03 +1000 (AEST) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id v3KC0fxE005369; Thu, 20 Apr 2017 07:00:42 -0500 Message-ID: <1492689640.25766.147.camel@kernel.crashing.org> From: Benjamin Herrenschmidt To: skiboot@lists.ozlabs.org Date: Thu, 20 Apr 2017 22:00:40 +1000 X-Mailer: Evolution 3.22.6 (3.22.6-1.fc25) Mime-Version: 1.0 Subject: [Skiboot] [PATCH] xive: Don't double EOI interrupts that have an EOI override X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Neuling Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Some interrupts source such as PSI serirq have a special EOI override. That override will perform the PQ bit EOI operation, so we must not do a second one in xive_source_eoi(). This bug can cause queue overflows, especially when dealing with runaway level interrupts. Signed-off-by: Benjamin Herrenschmidt --- This fixes the hangs on w18. It doesn't fix the massive slowdowns caused by runaway mbox interrupts which I will look into separately. hw/xive.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xive.c b/hw/xive.c index 530e0df..1e2648c 100644 --- a/hw/xive.c +++ b/hw/xive.c @@ -2531,8 +2531,8 @@ static void xive_source_eoi(struct irq_source *is, uint32_t isn) if (s->orig_ops && s->orig_ops->eoi) s->orig_ops->eoi(is, isn); - - __xive_source_eoi(is, isn); + else + __xive_source_eoi(is, isn); } static void xive_source_interrupt(struct irq_source *is, uint32_t isn)